* [PATCH] PCI: qcom: fix a bitwise vs logical NOT typo
@ 2018-05-01 7:22 Dan Carpenter
2018-05-09 23:08 ` Stanimir Varbanov
2018-05-16 11:23 ` Lorenzo Pieralisi
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-05-01 7:22 UTC (permalink / raw)
To: Stanimir Varbanov, John Crispin
Cc: Lorenzo Pieralisi, Bjorn Helgaas, linux-pci, kernel-janitors
There is a typo here so we accidentally set "val" to zero when we
intended just to clear BIT(0).
Fixes: 90d52d57ccac ("PCI: qcom: Add support for IPQ4019 PCIe controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Not tested.
diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
index 5897af7d3355..b65bbf7c284e 100644
--- a/drivers/pci/dwc/pcie-qcom.c
+++ b/drivers/pci/dwc/pcie-qcom.c
@@ -869,7 +869,7 @@ static int qcom_pcie_init_2_4_0(struct qcom_pcie *pcie)
/* enable PCIe clocks and resets */
val = readl(pcie->parf + PCIE20_PARF_PHY_CTRL);
- val &= !BIT(0);
+ val &= ~BIT(0);
writel(val, pcie->parf + PCIE20_PARF_PHY_CTRL);
/* change DBI base address */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: qcom: fix a bitwise vs logical NOT typo
2018-05-01 7:22 [PATCH] PCI: qcom: fix a bitwise vs logical NOT typo Dan Carpenter
@ 2018-05-09 23:08 ` Stanimir Varbanov
2018-05-16 2:49 ` John Crispin
2018-05-16 11:23 ` Lorenzo Pieralisi
1 sibling, 1 reply; 4+ messages in thread
From: Stanimir Varbanov @ 2018-05-09 23:08 UTC (permalink / raw)
To: Dan Carpenter, John Crispin
Cc: Lorenzo Pieralisi, Bjorn Helgaas, linux-pci, kernel-janitors
Hi Dan,
Thanks for the patch!
On 1.05.2018 10:22, Dan Carpenter wrote:
> There is a typo here so we accidentally set "val" to zero when we
> intended just to clear BIT(0).
>
> Fixes: 90d52d57ccac ("PCI: qcom: Add support for IPQ4019 PCIe controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 5897af7d3355..b65bbf7c284e 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -869,7 +869,7 @@ static int qcom_pcie_init_2_4_0(struct qcom_pcie *pcie)
>
> /* enable PCIe clocks and resets */
> val = readl(pcie->parf + PCIE20_PARF_PHY_CTRL);
> - val &= !BIT(0);
> + val &= ~BIT(0);
> writel(val, pcie->parf + PCIE20_PARF_PHY_CTRL);
>
> /* change DBI base address */
>
John, can you test that fix?
Otherwise the fix looks correct:
Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
regards,
Stan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: qcom: fix a bitwise vs logical NOT typo
2018-05-09 23:08 ` Stanimir Varbanov
@ 2018-05-16 2:49 ` John Crispin
0 siblings, 0 replies; 4+ messages in thread
From: John Crispin @ 2018-05-16 2:49 UTC (permalink / raw)
To: Stanimir Varbanov, Dan Carpenter
Cc: Lorenzo Pieralisi, Bjorn Helgaas, linux-pci, kernel-janitors
On 10/05/18 01:08, Stanimir Varbanov wrote:
> Hi Dan,
>
> Thanks for the patch!
>
> On 1.05.2018 10:22, Dan Carpenter wrote:
>> There is a typo here so we accidentally set "val" to zero when we
>> intended just to clear BIT(0).
>>
>> Fixes: 90d52d57ccac ("PCI: qcom: Add support for IPQ4019 PCIe
>> controller")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> Not tested.
>>
>> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
>> index 5897af7d3355..b65bbf7c284e 100644
>> --- a/drivers/pci/dwc/pcie-qcom.c
>> +++ b/drivers/pci/dwc/pcie-qcom.c
>> @@ -869,7 +869,7 @@ static int qcom_pcie_init_2_4_0(struct qcom_pcie
>> *pcie)
>> /* enable PCIe clocks and resets */
>> val = readl(pcie->parf + PCIE20_PARF_PHY_CTRL);
>> - val &= !BIT(0);
>> + val &= ~BIT(0);
>> writel(val, pcie->parf + PCIE20_PARF_PHY_CTRL);
>> /* change DBI base address */
>>
>
> John, can you test that fix?
>
> Otherwise the fix looks correct:
>
> Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
>
> regards,
> Stan
Acked-by: John Crispin <john@phrozen.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: qcom: fix a bitwise vs logical NOT typo
2018-05-01 7:22 [PATCH] PCI: qcom: fix a bitwise vs logical NOT typo Dan Carpenter
2018-05-09 23:08 ` Stanimir Varbanov
@ 2018-05-16 11:23 ` Lorenzo Pieralisi
1 sibling, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2018-05-16 11:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: Stanimir Varbanov, John Crispin, Bjorn Helgaas, linux-pci,
kernel-janitors
On Tue, May 01, 2018 at 10:22:50AM +0300, Dan Carpenter wrote:
> There is a typo here so we accidentally set "val" to zero when we
> intended just to clear BIT(0).
>
> Fixes: 90d52d57ccac ("PCI: qcom: Add support for IPQ4019 PCIe controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 5897af7d3355..b65bbf7c284e 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -869,7 +869,7 @@ static int qcom_pcie_init_2_4_0(struct qcom_pcie *pcie)
>
> /* enable PCIe clocks and resets */
> val = readl(pcie->parf + PCIE20_PARF_PHY_CTRL);
> - val &= !BIT(0);
> + val &= ~BIT(0);
> writel(val, pcie->parf + PCIE20_PARF_PHY_CTRL);
>
> /* change DBI base address */
Applied to pci/dwc for v4.18, thanks.
Lorenzo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-16 11:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 7:22 [PATCH] PCI: qcom: fix a bitwise vs logical NOT typo Dan Carpenter
2018-05-09 23:08 ` Stanimir Varbanov
2018-05-16 2:49 ` John Crispin
2018-05-16 11:23 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).