From: Bjorn Helgaas <helgaas@kernel.org>
To: Hari Vyas <hari.vyas@broadcom.com>
Cc: bhelgaas@google.com, benh@kernel.crashing.org,
linux-pci@vger.kernel.org, ray.jui@broadcom.com
Subject: Re: [PATCH v3] PCI: Data corruption happening due to race condition
Date: Tue, 31 Jul 2018 11:37:27 -0500 [thread overview]
Message-ID: <20180731163727.GK45322@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1530608741-30664-1-git-send-email-hari.vyas@broadcom.com>
On Tue, Jul 03, 2018 at 02:35:40PM +0530, Hari Vyas wrote:
> Changes in v3:
> As per review comments from Lukas Wunner <lukas@wunner.de>,
> squashed 3 commits to single commit. Without this build breaks.
> Also clubbed set and clear function for is_added bits to a
> single assign function. This optimizes code and reduce LoC.
> Removed one wrongly added blank line in pci.c
>
> Changes in v2:
> To avoid race condition while updating is_added and is_busmaster
> bits, is_added is moved to a private flag variable.
> is_added updation is handled in atomic manner also.
>
> Hari Vyas (1):
> PCI: Data corruption happening due to race condition
>
> arch/powerpc/kernel/pci-common.c | 4 +++-
> arch/powerpc/platforms/powernv/pci-ioda.c | 3 ++-
> arch/powerpc/platforms/pseries/setup.c | 3 ++-
> drivers/pci/bus.c | 6 +++---
> drivers/pci/hotplug/acpiphp_glue.c | 2 +-
> drivers/pci/pci.h | 11 +++++++++++
> drivers/pci/probe.c | 4 ++--
> drivers/pci/remove.c | 5 +++--
> include/linux/pci.h | 1 -
> 9 files changed, 27 insertions(+), 12 deletions(-)
Applied with Lukas' reviewed-by and Michael's ack to for-linus for v4.18,
thanks!
next prev parent reply other threads:[~2018-07-31 18:18 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 9:05 [PATCH v3] PCI: Data corruption happening due to race condition Hari Vyas
2018-07-03 9:05 ` Hari Vyas
2018-07-03 9:13 ` Lukas Wunner
2018-07-18 23:29 ` Bjorn Helgaas
2018-07-19 4:18 ` Benjamin Herrenschmidt
2018-07-19 14:04 ` Hari Vyas
2018-07-19 18:55 ` Lukas Wunner
2018-07-20 4:27 ` Benjamin Herrenschmidt
2018-07-27 22:25 ` Bjorn Helgaas
2018-07-28 0:45 ` Benjamin Herrenschmidt
2018-07-31 11:21 ` Michael Ellerman
2018-07-19 17:41 ` Bjorn Helgaas
2018-07-20 9:16 ` Hari Vyas
2018-07-20 12:20 ` Bjorn Helgaas
2018-07-31 16:37 ` Bjorn Helgaas [this message]
2018-08-15 3:35 ` PCIe enable device races (Was: [PATCH v3] PCI: Data corruption happening due to race condition) Benjamin Herrenschmidt
2018-08-15 4:16 ` Benjamin Herrenschmidt
2018-08-15 4:44 ` Benjamin Herrenschmidt
2018-08-15 5:21 ` [RFC PATCH] pci: Proof of concept at fixing pci_enable_device/bridge races Benjamin Herrenschmidt
2018-08-15 19:09 ` PCIe enable device races (Was: [PATCH v3] PCI: Data corruption happening due to race condition) Bjorn Helgaas
2018-08-15 21:50 ` [RFC PATCH] pci: Proof of concept at fixing pci_enable_device/bridge races Benjamin Herrenschmidt
2018-08-15 22:40 ` Guenter Roeck
2018-08-15 23:38 ` Benjamin Herrenschmidt
2018-08-20 1:31 ` Guenter Roeck
2018-08-17 3:07 ` Bjorn Helgaas
2018-08-17 3:42 ` Benjamin Herrenschmidt
2018-08-15 18:50 ` PCIe enable device races (Was: [PATCH v3] PCI: Data corruption happening due to race condition) Bjorn Helgaas
2018-08-15 21:52 ` Benjamin Herrenschmidt
2018-08-15 23:23 ` Benjamin Herrenschmidt
2018-08-16 7:58 ` Konstantin Khlebnikov
2018-08-16 8:02 ` Benjamin Herrenschmidt
2018-08-16 9:22 ` Hari Vyas
2018-08-16 10:10 ` Benjamin Herrenschmidt
2018-08-16 10:11 ` Benjamin Herrenschmidt
2018-08-16 10:26 ` Lukas Wunner
2018-08-16 10:47 ` Hari Vyas
2018-08-16 23:20 ` Benjamin Herrenschmidt
2018-08-16 23:17 ` Benjamin Herrenschmidt
2018-08-17 0:43 ` Benjamin Herrenschmidt
2018-08-16 19:43 ` Jens Axboe
2018-08-16 21:37 ` Benjamin Herrenschmidt
2018-08-16 21:56 ` Jens Axboe
2018-08-16 23:09 ` Benjamin Herrenschmidt
2018-08-17 0:14 ` Jens Axboe
2018-08-16 12:28 ` Lukas Wunner
2018-08-16 23:25 ` Benjamin Herrenschmidt
2018-08-17 1:12 ` Benjamin Herrenschmidt
2018-08-17 16:39 ` Lukas Wunner
2018-08-18 3:37 ` Benjamin Herrenschmidt
2018-08-18 9:22 ` Lukas Wunner
2018-08-18 13:11 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731163727.GK45322@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=hari.vyas@broadcom.com \
--cc=linux-pci@vger.kernel.org \
--cc=ray.jui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).