From: Lukas Wunner <lukas@wunner.de>
To: Sinan Kaya <okaya@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Oza Pawandeep <poza@codeaurora.org>,
Keith Busch <keith.busch@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 1/2] PCI: pciehp: Ignore link events when there is a fatal error pending
Date: Mon, 20 Aug 2018 11:22:38 +0200 [thread overview]
Message-ID: <20180820092238.kvktwlovc64oa66e@wunner.de> (raw)
In-Reply-To: <20180818065126.77912-1-okaya@kernel.org>
On Fri, Aug 17, 2018 at 11:51:09PM -0700, Sinan Kaya wrote:
> --- a/drivers/pci/hotplug/pciehp_ctrl.c
> +++ b/drivers/pci/hotplug/pciehp_ctrl.c
> @@ -222,9 +222,27 @@ void pciehp_handle_disable_request(struct slot *slot)
> void pciehp_handle_presence_or_link_change(struct slot *slot, u32 events)
> {
> struct controller *ctrl = slot->ctrl;
> + struct pci_dev *pdev = ctrl->pcie->port;
> bool link_active;
> u8 present;
>
> + /* If a fatal error is pending, wait for AER or DPC to handle it. */
> + if (pcie_fatal_error_pending(pdev)) {
> + bool recovered;
> +
> + recovered = pcie_wait_fatal_error_clear(pdev);
> +
> + /* If the fatal error is gone and the link is up, return */
> + if (recovered && pcie_wait_for_link(pdev, true)) {
> + ctrl_info(ctrl, "Slot(%s): Ignoring Link event due to successful fatal error recovery\n",
> + slot_name(slot));
> + return;
> + }
> +
> + ctrl_info(ctrl, "Slot(%s): Fatal error recovery failed for Link event, trying hotplug reset\n",
> + slot_name(slot));
> + }
> +
This differs from v7 of the patch in that *any* fatal error, not just
a Surprise Link Down, results in pciehp waiting for the error to clear.
I'm wondering if that's safe: Theoretically, the user might quickly
swap the card in the slot during, say, a Completion Timeout Error,
and with this patch pciehp would carry on as if nothing happened.
Thanks,
Lukas
next prev parent reply other threads:[~2018-08-20 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 6:51 [PATCH v8 1/2] PCI: pciehp: Ignore link events when there is a fatal error pending Sinan Kaya
2018-08-18 6:51 ` [PATCH v8 2/2] PCI: pciehp: Mask AER surprise link down error if hotplug is enabled Sinan Kaya
2018-08-19 23:23 ` Sinan Kaya
2018-08-20 0:20 ` kbuild test robot
2018-08-20 8:21 ` Lukas Wunner
2018-08-20 17:43 ` Sinan Kaya
2018-08-20 9:22 ` Lukas Wunner [this message]
2018-08-20 16:59 ` [PATCH v8 1/2] PCI: pciehp: Ignore link events when there is a fatal error pending Sinan Kaya
2018-08-20 17:22 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820092238.kvktwlovc64oa66e@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@kernel.org \
--cc=poza@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).