From: Joerg Roedel <joro@8bytes.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org,
jcrouse@codeaurora.org, alex.williamson@redhat.com,
Jonathan.Cameron@huawei.com, jacob.jun.pan@linux.intel.com,
christian.koenig@amd.com, eric.auger@redhat.com,
kevin.tian@intel.com, yi.l.liu@intel.com, andrew.murray@arm.com,
will.deacon@arm.com, robin.murphy@arm.com, ashok.raj@intel.com,
xuzaibo@huawei.com, liguozhu@hisilicon.com, okaya@codeaurora.org,
bharatku@xilinx.com, ilias.apalodimas@linaro.org,
shunyong.yang@hxt-semitech.com
Subject: Re: [PATCH v3 01/10] iommu: Introduce Shared Virtual Addressing API
Date: Tue, 25 Sep 2018 15:16:47 +0200 [thread overview]
Message-ID: <20180925131647.rygncwik5uszsm3n@8bytes.org> (raw)
In-Reply-To: <f406bcf7-4e54-9f1b-88eb-03fc642ffede@linux.intel.com>
On Sun, Sep 23, 2018 at 10:39:25AM +0800, Lu Baolu wrote:
> > +int iommu_sva_init_device(struct device *dev, unsigned long features,
> > + unsigned int min_pasid, unsigned int max_pasid)
> > +{
> > + int ret;
> > + struct iommu_sva_param *param;
> > + struct iommu_domain *domain = iommu_get_domain_for_dev(dev);
>
> This doesn't work for vt-d. The domains for host iova are self-managed
> by vt-d driver itself. Hence, iommu_get_domain_for_dev() will always
> return NULL unless an UNMANAGED domain is attached to the device.
>
> How about
>
> const struct iommu_ops *ops = dev->bus->iommu_ops;
>
> instead?
The per-bus iommu-ops might go away sooner or later as we move to
per-device iommu-ops. How about fixing the VT-d driver to not keep that
domain internal to itself?
Regards,
Joerg
next prev parent reply other threads:[~2018-09-25 13:16 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 17:00 [PATCH v3 00/10] Shared Virtual Addressing for the IOMMU Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 01/10] iommu: Introduce Shared Virtual Addressing API Jean-Philippe Brucker
[not found] ` <f406bcf7-4e54-9f1b-88eb-03fc642ffede@linux.intel.com>
2018-09-24 12:07 ` Jean-Philippe Brucker
2018-09-25 13:16 ` Joerg Roedel [this message]
2018-09-25 22:46 ` Jacob Pan
2018-09-26 10:14 ` Jean-Philippe Brucker
2018-09-26 12:48 ` Joerg Roedel
2018-09-20 17:00 ` [PATCH v3 02/10] iommu/sva: Bind process address spaces to devices Jean-Philippe Brucker
2018-09-23 3:05 ` Lu Baolu
2018-09-24 12:07 ` Jean-Philippe Brucker
2018-09-26 18:01 ` Jacob Pan
2018-09-27 15:06 ` Jean-Philippe Brucker
2018-09-28 1:14 ` Tian, Kevin
2018-09-20 17:00 ` [PATCH v3 03/10] iommu/sva: Manage process address spaces Jean-Philippe Brucker
2018-09-25 3:15 ` Lu Baolu
2018-09-25 10:32 ` Jean-Philippe Brucker
2018-09-26 3:12 ` Lu Baolu
2018-09-25 13:26 ` Joerg Roedel
2018-09-25 23:33 ` Lu Baolu
2018-09-26 10:20 ` Jean-Philippe Brucker
2018-09-26 12:45 ` Joerg Roedel
2018-09-26 13:50 ` Jean-Philippe Brucker
2018-09-27 3:22 ` Liu, Yi L
2018-09-27 13:37 ` Jean-Philippe Brucker
2018-10-08 8:29 ` Liu, Yi L
2018-09-26 22:58 ` Jacob Pan
2018-09-26 22:35 ` Jacob Pan
2018-10-03 17:52 ` Jean-Philippe Brucker
2018-10-15 20:53 ` Jacob Pan
2018-09-20 17:00 ` [PATCH v3 04/10] iommu/sva: Add a mm_exit callback for device drivers Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 05/10] iommu/sva: Track mm changes with an MMU notifier Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 06/10] iommu/sva: Search mm by PASID Jean-Philippe Brucker
2018-09-25 4:59 ` Lu Baolu
2018-09-20 17:00 ` [PATCH v3 07/10] iommu: Add a page fault handler Jean-Philippe Brucker
2018-09-27 20:37 ` Jacob Pan
2018-10-03 17:46 ` Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 08/10] iommu/iopf: Handle mm faults Jean-Philippe Brucker
2018-09-20 17:00 ` [PATCH v3 09/10] iommu/sva: Register page fault handler Jean-Philippe Brucker
2018-09-20 17:00 ` [RFC PATCH v3 10/10] iommu/sva: Add support for private PASIDs Jean-Philippe Brucker
2018-10-12 14:32 ` Jordan Crouse
2018-10-17 14:21 ` Jean-Philippe Brucker
2018-10-17 14:24 ` Jean-Philippe Brucker
2018-10-17 15:07 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925131647.rygncwik5uszsm3n@8bytes.org \
--to=joro@8bytes.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=andrew.murray@arm.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bharatku@xilinx.com \
--cc=christian.koenig@amd.com \
--cc=eric.auger@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jcrouse@codeaurora.org \
--cc=jean-philippe.brucker@arm.com \
--cc=kevin.tian@intel.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=shunyong.yang@hxt-semitech.com \
--cc=will.deacon@arm.com \
--cc=xuzaibo@huawei.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).