* [PATCH 1/1] PCI: mobiveil: fix multi function endpoint failures
@ 2018-11-05 12:51 Subrahmanya Lingappa
2018-11-05 12:51 ` [PATCH v2] " Subrahmanya Lingappa
0 siblings, 1 reply; 4+ messages in thread
From: Subrahmanya Lingappa @ 2018-11-05 12:51 UTC (permalink / raw)
To: linux-pci, bhelgaas, lorenzo.pieralisi; +Cc: Subrahmanya Lingappa
The fix enables mobiveil pcie controller to detect more than one
functions per device. Also increases the MSI interrupts.
Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support")
Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP
driver")
Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
---
drivers/pci/controller/pcie-mobiveil.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
index 4d6c20e..113d56a 100644
--- a/drivers/pci/controller/pcie-mobiveil.c
+++ b/drivers/pci/controller/pcie-mobiveil.c
@@ -89,7 +89,7 @@
#define PAB_INTX_START 5
/* supported number of MSI interrupts */
-#define PCI_NUM_MSI 16
+#define PCI_NUM_MSI 256
/* MSI registers */
#define MSI_BASE_LO_OFFSET 0x04
@@ -172,7 +172,7 @@ static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
* Do not read more than one device on the bus directly
* attached to RC
*/
- if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
+ if ((bus->number == pcie->root_bus_nr) && (devfn > 0))
return false;
return true;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] PCI: mobiveil: fix multi function endpoint failures
2018-11-05 12:51 [PATCH 1/1] PCI: mobiveil: fix multi function endpoint failures Subrahmanya Lingappa
@ 2018-11-05 12:51 ` Subrahmanya Lingappa
2018-11-06 14:24 ` Lorenzo Pieralisi
0 siblings, 1 reply; 4+ messages in thread
From: Subrahmanya Lingappa @ 2018-11-05 12:51 UTC (permalink / raw)
To: linux-pci, bhelgaas, lorenzo.pieralisi; +Cc: Subrahmanya Lingappa
The fix enables mobiveil pcie controller to detect more than one
functions per device. Also increases the MSI interrupts.
Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support")
Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP
driver")
Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
---
drivers/pci/controller/pcie-mobiveil.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
index 4d6c20e..113d56a 100644
--- a/drivers/pci/controller/pcie-mobiveil.c
+++ b/drivers/pci/controller/pcie-mobiveil.c
@@ -89,7 +89,7 @@
#define PAB_INTX_START 5
/* supported number of MSI interrupts */
-#define PCI_NUM_MSI 16
+#define PCI_NUM_MSI 256
/* MSI registers */
#define MSI_BASE_LO_OFFSET 0x04
@@ -172,7 +172,7 @@ static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
* Do not read more than one device on the bus directly
* attached to RC
*/
- if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
+ if ((bus->number == pcie->root_bus_nr) && (devfn > 0))
return false;
return true;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PCI: mobiveil: fix multi function endpoint failures
2018-11-05 12:51 ` [PATCH v2] " Subrahmanya Lingappa
@ 2018-11-06 14:24 ` Lorenzo Pieralisi
2018-11-07 6:10 ` Subrahmanya Lingappa
0 siblings, 1 reply; 4+ messages in thread
From: Lorenzo Pieralisi @ 2018-11-06 14:24 UTC (permalink / raw)
To: Subrahmanya Lingappa; +Cc: linux-pci, bhelgaas
On Mon, Nov 05, 2018 at 07:51:41AM -0500, Subrahmanya Lingappa wrote:
> The fix enables mobiveil pcie controller to detect more than one
> functions per device. Also increases the MSI interrupts.
1 patch, 1 logical change, you are making 1 patch 2 logical changes,
split the patch in two and repost them please.
I will consider patch v1 obsolete too, no idea why it was posted.
Lorenzo
> Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support")
> Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP
> driver")
> Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
> ---
> drivers/pci/controller/pcie-mobiveil.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
> index 4d6c20e..113d56a 100644
> --- a/drivers/pci/controller/pcie-mobiveil.c
> +++ b/drivers/pci/controller/pcie-mobiveil.c
> @@ -89,7 +89,7 @@
> #define PAB_INTX_START 5
>
> /* supported number of MSI interrupts */
> -#define PCI_NUM_MSI 16
> +#define PCI_NUM_MSI 256
>
> /* MSI registers */
> #define MSI_BASE_LO_OFFSET 0x04
> @@ -172,7 +172,7 @@ static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
> * Do not read more than one device on the bus directly
> * attached to RC
> */
> - if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
> + if ((bus->number == pcie->root_bus_nr) && (devfn > 0))
> return false;
>
> return true;
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PCI: mobiveil: fix multi function endpoint failures
2018-11-06 14:24 ` Lorenzo Pieralisi
@ 2018-11-07 6:10 ` Subrahmanya Lingappa
0 siblings, 0 replies; 4+ messages in thread
From: Subrahmanya Lingappa @ 2018-11-07 6:10 UTC (permalink / raw)
To: Lorenzo Pieralisi; +Cc: linux-pci, Bjorn Helgaas
Lorenzo,
Will do, thanks!
Yes please ignore the patch v1.
Thanks.
On Tue, Nov 6, 2018 at 7:54 PM Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Mon, Nov 05, 2018 at 07:51:41AM -0500, Subrahmanya Lingappa wrote:
> > The fix enables mobiveil pcie controller to detect more than one
> > functions per device. Also increases the MSI interrupts.
>
> 1 patch, 1 logical change, you are making 1 patch 2 logical changes,
> split the patch in two and repost them please.
>
> I will consider patch v1 obsolete too, no idea why it was posted.
>
> Lorenzo
>
> > Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support")
> > Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP
> > driver")
> > Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
> > ---
> > drivers/pci/controller/pcie-mobiveil.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
> > index 4d6c20e..113d56a 100644
> > --- a/drivers/pci/controller/pcie-mobiveil.c
> > +++ b/drivers/pci/controller/pcie-mobiveil.c
> > @@ -89,7 +89,7 @@
> > #define PAB_INTX_START 5
> >
> > /* supported number of MSI interrupts */
> > -#define PCI_NUM_MSI 16
> > +#define PCI_NUM_MSI 256
> >
> > /* MSI registers */
> > #define MSI_BASE_LO_OFFSET 0x04
> > @@ -172,7 +172,7 @@ static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
> > * Do not read more than one device on the bus directly
> > * attached to RC
> > */
> > - if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
> > + if ((bus->number == pcie->root_bus_nr) && (devfn > 0))
> > return false;
> >
> > return true;
> > --
> > 1.8.3.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-07 6:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05 12:51 [PATCH 1/1] PCI: mobiveil: fix multi function endpoint failures Subrahmanya Lingappa
2018-11-05 12:51 ` [PATCH v2] " Subrahmanya Lingappa
2018-11-06 14:24 ` Lorenzo Pieralisi
2018-11-07 6:10 ` Subrahmanya Lingappa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).