From: Lukas Wunner <lukas@wunner.de>
To: Thinh Nguyen <thinh.nguyen@synopsys.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Lukas F. Hartmann" <lukas@mntmn.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lucas Stach <l.stach@pengutronix.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Youn <john.youn@synopsys.com>
Subject: Re: Linux Kernel Regression: HAPS quirk breaks PCIe on i.MX6QP
Date: Fri, 1 Feb 2019 09:59:06 +0100 [thread overview]
Message-ID: <20190201085906.tqp6ysbb65n7jfkv@wunner.de> (raw)
In-Reply-To: <30102591E157244384E984126FC3CB4F639BECAB@us01wembx1.internal.synopsys.com>
On Thu, Jan 31, 2019 at 11:46:23PM +0000, Thinh Nguyen wrote:
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -629,6 +629,9 @@ static void quirk_synopsys_haps(struct pci_dev *pdev)
> {
> u32 class = pdev->class;
>
> + if (class != PCI_CLASS_SERIAL_USB_XHCI)
> + return;
> +
> switch (pdev->device) {
> case PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3:
> case PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI:
Please use DECLARE_PCI_FIXUP_CLASS_HEADER() instead.
Thanks,
Lukas
next prev parent reply other threads:[~2019-02-01 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87o97wrbef.fsf@mntmn.com>
2019-01-31 21:49 ` Linux Kernel Regression: HAPS quirk breaks PCIe on i.MX6QP Bjorn Helgaas
2019-01-31 22:50 ` Thinh Nguyen
2019-01-31 23:46 ` Thinh Nguyen
2019-02-01 8:05 ` Lukas Hartmann
2019-02-01 20:22 ` Thinh Nguyen
2019-02-01 8:59 ` Lukas Wunner [this message]
2019-02-01 20:27 ` Thinh Nguyen
2019-02-05 20:09 ` Bjorn Helgaas
2019-02-05 20:38 ` Thinh Nguyen
2019-02-05 20:59 ` Bjorn Helgaas
2019-02-05 21:02 ` Thinh Nguyen
2019-02-05 21:33 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201085906.tqp6ysbb65n7jfkv@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.youn@synopsys.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@mntmn.com \
--cc=thinh.nguyen@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).