From: Vidya Sagar <vidyas@nvidia.com>
To: <bhelgaas@google.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <kishon@ti.com>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<lorenzo.pieralisi@arm.com>, <jingoohan1@gmail.com>,
<gustavo.pimentel@synopsys.com>
Cc: <mperttunen@nvidia.com>, <linux-pci@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kthota@nvidia.com>,
<mmaddireddy@nvidia.com>, <vidyas@nvidia.com>,
<sagar.tv@gmail.com>
Subject: [PATCH V3 04/16] PCI: dwc: Perform dbi regs write lock towards the end
Date: Wed, 17 Apr 2019 00:57:18 +0530 [thread overview]
Message-ID: <20190416192730.15681-5-vidyas@nvidia.com> (raw)
In-Reply-To: <20190416192730.15681-1-vidyas@nvidia.com>
Remove multiple write enable and disable sequences of dbi registers as
Tegra194 implements writes to BAR-0 register (offset: 0x10) controlled by
DBI write-lock enable bit thereby not allowing any further writes to BAR-0
register in config space to take place. Hence disabling write permission
only towards the end.
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
Changes since [v2]:
* None
Changes since [v1]:
* None
drivers/pci/controller/dwc/pcie-designware-host.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 2a5332e5ccfa..c0334c92c1a6 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -683,7 +683,6 @@ void dw_pcie_setup_rc(struct pcie_port *pp)
val &= 0xffff00ff;
val |= 0x00000100;
dw_pcie_writel_dbi(pci, PCI_INTERRUPT_LINE, val);
- dw_pcie_dbi_ro_wr_dis(pci);
/* Setup bus numbers */
val = dw_pcie_readl_dbi(pci, PCI_PRIMARY_BUS);
@@ -723,8 +722,6 @@ void dw_pcie_setup_rc(struct pcie_port *pp)
dw_pcie_wr_own_conf(pp, PCI_BASE_ADDRESS_0, 4, 0);
- /* Enable write permission for the DBI read-only register */
- dw_pcie_dbi_ro_wr_en(pci);
/* Program correct class for RC */
dw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI);
/* Better disable write permission right after the update */
--
2.17.1
next prev parent reply other threads:[~2019-04-16 19:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 19:27 [PATCH V3 00/16] Add Tegra194 PCIe support Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 01/16] PCI: Add #defines for some of PCIe spec r4.0 features Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 02/16] PCI/PME: Export pcie_pme_disable_msi() & pcie_pme_no_msi() APIs Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 03/16] PCI: Export pcie_bus_config symbol Vidya Sagar
2019-04-16 19:27 ` Vidya Sagar [this message]
2019-04-17 9:56 ` [PATCH V3 04/16] PCI: dwc: Perform dbi regs write lock towards the end Gustavo Pimentel
2019-04-22 7:54 ` Jisheng Zhang
2019-04-23 6:11 ` Vidya Sagar
2019-04-23 9:40 ` Gustavo Pimentel
2019-04-30 0:36 ` [EXT] " Z.q. Hou
2019-04-16 19:27 ` [PATCH V3 05/16] PCI: dwc: Move config space capability search API Vidya Sagar
2019-04-17 9:28 ` Gustavo Pimentel
2019-04-16 19:27 ` [PATCH V3 06/16] PCI: dwc: Add ext " Vidya Sagar
2019-04-17 9:27 ` Gustavo Pimentel
2019-04-17 9:34 ` Vidya Sagar
2019-04-17 9:46 ` Gustavo Pimentel
2019-04-16 19:27 ` [PATCH V3 07/16] dt-bindings: PCI: designware: Add binding for CDM register check Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 08/16] PCI: dwc: Add support to enable " Vidya Sagar
2019-04-17 9:39 ` Gustavo Pimentel
2019-04-16 19:27 ` [PATCH V3 09/16] Documentation/devicetree: Add PCIe supports-clkreq property Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 10/16] dt-bindings: PCI: tegra: Add device tree support for T194 Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 11/16] dt-bindings: PHY: P2U: Add Tegra 194 P2U block Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 12/16] arm64: tegra: Add P2U and PCIe controller nodes to Tegra194 DT Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 13/16] arm64: tegra: Enable PCIe slots in P2972-0000 board Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 14/16] phy: tegra: Add PCIe PIPE2UPHY support Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 15/16] PCI: tegra: Add Tegra194 PCIe support Vidya Sagar
2019-04-16 19:27 ` [PATCH V3 16/16] arm64: Add Tegra194 PCIe driver to defconfig Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416192730.15681-5-vidyas@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=kthota@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).