linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	PCI <linux-pci@vger.kernel.org>,
	MSM <linux-arm-msm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Jeffrey Hugo <jhugo@codeaurora.org>
Subject: Re: [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class
Date: Tue, 30 Apr 2019 15:06:21 +0100	[thread overview]
Message-ID: <20190430140621.GB18742@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <38ad143b-3b07-4d19-8ccd-ca39fb51e53d@free.fr>

On Tue, Mar 12, 2019 at 06:34:55PM +0100, Marc Gonzalez wrote:
> On 12/03/2019 18:18, Marc Gonzalez wrote:
> 
> > On 12/03/2019 13:42, Stanimir Varbanov wrote:
> > 
> >> I wonder, in case that dw_pcie_setup_rc() already has a write to
> >> PCI_CLASS_DEVICE configuration register to set it as a bridge do we
> >> still need to do the above fixup?
> > 
> > I don't know, I don't have an affected device. Unless the msm8998 /is/ affected,
> > and dw_pcie_setup_rc() actually fixes it?
> 
> I think you hit the nail on the head...
> 
> If I comment out
> //dw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI);
> from dw_pcie_setup_rc()
> then pci_class() returns 0xff000000 instead of 0x6040000
> 
> So perhaps you're right: the quirk can be omitted altogether.
> Unless it is not possible to program the device class on older chips?

Marc,

I would drop this patch from the PCI queue since in a different
form it was already merged, please let me know if I am wrong.

Thanks,
Lorenzo

  parent reply	other threads:[~2019-04-30 14:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 14:56 [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class Marc Gonzalez
2019-03-12 12:42 ` Stanimir Varbanov
2019-03-12 17:18   ` Marc Gonzalez
2019-03-12 17:34     ` Marc Gonzalez
2019-03-13 11:45       ` [PATCH v2] PCI: qcom: Use default config space read function Marc Gonzalez
2019-03-13 13:13         ` Marc Gonzalez
2019-03-13 18:29         ` Srinivas Kandagatla
2019-03-13 20:39           ` Marc Gonzalez
2019-03-13 21:52             ` Srinivas Kandagatla
2019-03-13 22:26               ` Marc Gonzalez
2019-03-14 11:10                 ` Srinivas Kandagatla
2019-03-14 13:18                   ` Marc Gonzalez
2019-03-18 14:28                     ` [PATCH v3] " Marc Gonzalez
2019-03-18 14:39                       ` Srinivas Kandagatla
2019-03-18 16:35                       ` Stanimir Varbanov
2019-03-18 17:14                         ` [PATCH v4] " Marc Gonzalez
2019-03-25 12:11                           ` Marc Gonzalez
2019-03-25 13:32                             ` Stanimir Varbanov
2019-03-25 15:42                               ` [PATCH v5] " Marc Gonzalez
2019-03-29 13:48                                 ` Marc Gonzalez
2019-03-29 15:55                                 ` Stanimir Varbanov
2019-03-29 16:38                                 ` Lorenzo Pieralisi
2019-04-01 10:39                                   ` Marc Gonzalez
2019-04-01 11:12                                     ` Lorenzo Pieralisi
2019-04-30 14:06       ` Lorenzo Pieralisi [this message]
2019-05-02  9:42         ` [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class Marc Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430140621.GB18742@e121166-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=andy.gross@linaro.org \
    --cc=bhelgaas@google.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=svarbanov@mm-sol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).