From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
PCI <linux-pci@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>
Subject: Re: [PATCH v2] PCI: qcom: Use default config space read function
Date: Wed, 13 Mar 2019 21:39:43 +0100 [thread overview]
Message-ID: <2f901228-52db-7661-8257-ca8fd2ff2a46@free.fr> (raw)
In-Reply-To: <3c76613e-e60d-94b8-dd6f-b8f4e1928263@linaro.org>
On 13/03/2019 19:29, Srinivas Kandagatla wrote:
> On 13/03/2019 11:45, Marc Gonzalez wrote:
>
>> We don't need to fudge the device class in qcom_pcie_rd_own_conf()
>> because dw_pcie_setup_rc() already does the right thing:
>>
>> /* Program correct class for RC */
>> dw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI);
>>
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
>> ---
>> Changes from v1 to v2: Completely drop qcom_pcie_rd_own_conf
>> Srinivas, could you test this patch on apq/ipq8064?
>> ---
>> drivers/pci/controller/dwc/pcie-qcom.c | 17 -----------------
>> 1 file changed, 17 deletions(-)
>>
> I tried this patch on IFC6410 board which has APQ8064, and the pci does
> not work anymore after applying this patch.
>
> non-working output of 'lspci -vvv'
> https://paste.ubuntu.com/p/ndmdsW4zkJ/ and bootlog
> https://paste.ubuntu.com/p/CqVzGymnq8/
>
> working without patch : https://paste.ubuntu.com/p/TJm4hgjGW4/
>
> I have not debugged it any further other than just testing the patch.
> Let me know if you need any more dumps for more debug.
Could you pastebin the output of lspci -vvv -n in the working case?
I think that programming the device class might not work on APQ8064,
and therefore that platform requires the quirk.
So maybe I can add the quirk back, just for APQ8064?
Regards.
next prev parent reply other threads:[~2019-03-13 20:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 14:56 [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class Marc Gonzalez
2019-03-12 12:42 ` Stanimir Varbanov
2019-03-12 17:18 ` Marc Gonzalez
2019-03-12 17:34 ` Marc Gonzalez
2019-03-13 11:45 ` [PATCH v2] PCI: qcom: Use default config space read function Marc Gonzalez
2019-03-13 13:13 ` Marc Gonzalez
2019-03-13 18:29 ` Srinivas Kandagatla
2019-03-13 20:39 ` Marc Gonzalez [this message]
2019-03-13 21:52 ` Srinivas Kandagatla
2019-03-13 22:26 ` Marc Gonzalez
2019-03-14 11:10 ` Srinivas Kandagatla
2019-03-14 13:18 ` Marc Gonzalez
2019-03-18 14:28 ` [PATCH v3] " Marc Gonzalez
2019-03-18 14:39 ` Srinivas Kandagatla
2019-03-18 16:35 ` Stanimir Varbanov
2019-03-18 17:14 ` [PATCH v4] " Marc Gonzalez
2019-03-25 12:11 ` Marc Gonzalez
2019-03-25 13:32 ` Stanimir Varbanov
2019-03-25 15:42 ` [PATCH v5] " Marc Gonzalez
2019-03-29 13:48 ` Marc Gonzalez
2019-03-29 15:55 ` Stanimir Varbanov
2019-03-29 16:38 ` Lorenzo Pieralisi
2019-04-01 10:39 ` Marc Gonzalez
2019-04-01 11:12 ` Lorenzo Pieralisi
2019-04-30 14:06 ` [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class Lorenzo Pieralisi
2019-05-02 9:42 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f901228-52db-7661-8257-ca8fd2ff2a46@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=andy.gross@linaro.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).