From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ashok.raj@intel.com, keith.busch@intel.com
Subject: Re: [PATCH v5 3/7] PCI/ATS: Initialize PASID in pci_ats_init()
Date: Thu, 15 Aug 2019 10:31:34 -0700 [thread overview]
Message-ID: <20190815173134.GC139211@skuppusw-desk.amr.corp.intel.com> (raw)
In-Reply-To: <20190815045659.GF253360@google.com>
On Wed, Aug 14, 2019 at 11:56:59PM -0500, Bjorn Helgaas wrote:
> On Thu, Aug 01, 2019 at 05:06:00PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> >
> > Currently, PASID Capability checks are repeated across all PASID API's.
> > Instead, cache the capability check result in pci_pasid_init() and use
> > it in other PASID API's. Also, since PASID is a shared resource between
> > PF/VF, initialize PASID features with default values in pci_pasid_init().
> >
> > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> > + * TODO: Since PASID is a shared resource between PF/VF, don't update
> > + * PASID features in the same API as a per device feature.
>
> This comment is slightly misleading (at least, it misled *me* :))
> because it hints that PASID might be specific to SR-IOV. But I don't
> think that's true, so if you keep a comment like this, please reword
> it along the lines of "for SR-IOV devices, the PF's PASID is shared
> between the PF and all VFs" so it leaves open the possibility of
> non-SR-IOV devices using PASID as well.
Ok. I will fix it in next version.
>
> Bjorn
--
--
Sathyanarayanan Kuppuswamy
Linux kernel developer
next prev parent reply other threads:[~2019-08-15 17:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 0:05 [PATCH v5 0/7] Fix PF/VF dependency issue sathyanarayanan.kuppuswamy
2019-08-02 0:05 ` [PATCH v5 1/7] PCI/ATS: Fix pci_prg_resp_pasid_required() dependency issues sathyanarayanan.kuppuswamy
2019-08-12 20:04 ` Bjorn Helgaas
2019-08-12 20:20 ` sathyanarayanan kuppuswamy
2019-08-13 3:51 ` Bjorn Helgaas
2019-08-16 18:06 ` Kuppuswamy Sathyanarayanan
2019-08-02 0:05 ` [PATCH v5 2/7] PCI/ATS: Initialize PRI in pci_ats_init() sathyanarayanan.kuppuswamy
2019-08-12 20:04 ` Bjorn Helgaas
2019-08-12 21:35 ` sathyanarayanan kuppuswamy
2019-08-13 4:10 ` Bjorn Helgaas
2019-08-15 4:46 ` Bjorn Helgaas
2019-08-15 17:30 ` Kuppuswamy Sathyanarayanan
2019-08-16 17:31 ` Bjorn Helgaas
2019-08-02 0:06 ` [PATCH v5 3/7] PCI/ATS: Initialize PASID " sathyanarayanan.kuppuswamy
2019-08-12 20:04 ` Bjorn Helgaas
2019-08-15 4:48 ` Bjorn Helgaas
2019-08-15 4:56 ` Bjorn Helgaas
2019-08-15 17:31 ` Kuppuswamy Sathyanarayanan [this message]
2019-08-02 0:06 ` [PATCH v5 4/7] PCI/ATS: Add PRI support for PCIe VF devices sathyanarayanan.kuppuswamy
2019-08-12 20:04 ` Bjorn Helgaas
2019-08-12 21:40 ` sathyanarayanan kuppuswamy
2019-08-13 4:16 ` Bjorn Helgaas
2019-08-15 22:20 ` Bjorn Helgaas
2019-08-15 22:39 ` Kuppuswamy Sathyanarayanan
2019-08-19 14:15 ` Bjorn Helgaas
2019-08-19 22:53 ` Kuppuswamy Sathyanarayanan
2019-08-19 23:19 ` Bjorn Helgaas
2019-08-28 18:21 ` Kuppuswamy Sathyanarayanan
2019-08-28 18:57 ` Bjorn Helgaas
2019-08-02 0:06 ` [PATCH v5 5/7] PCI/ATS: Add PASID " sathyanarayanan.kuppuswamy
2019-08-12 20:05 ` Bjorn Helgaas
2019-08-13 22:19 ` Kuppuswamy Sathyanarayanan
2019-08-15 5:04 ` Bjorn Helgaas
2019-08-16 1:21 ` Kuppuswamy Sathyanarayanan
2019-08-02 0:06 ` [PATCH v5 6/7] PCI/ATS: Disable PF/VF ATS service independently sathyanarayanan.kuppuswamy
2019-08-02 0:06 ` [PATCH v5 7/7] PCI: Skip Enhanced Allocation (EA) initialization for VF device sathyanarayanan.kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815173134.GC139211@skuppusw-desk.amr.corp.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).