Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
* reverting c37e627f9565368ed7bd1f3cf59a2d223ddba85a
@ 2019-08-20  5:15 Prasad Koya
  2019-08-20 10:02 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Prasad Koya @ 2019-08-20  5:15 UTC (permalink / raw)
  To: fred; +Cc: linux-pci

hi Frederick

At Arista Networks, we have a service driver for AER as a loadable
module. The reasons for having Arista's own module and not enabling
in-built aer driver (CONFIG_PCIEAER) is for the reasons below:

1. We need this driver on a few of our 40+ products we sell at this
time. So we want to keep this as a module and load it only on hardware
that supports AER.

2. Reacting to the type of PCI error is handled by a user space
process, not a kernel thread. So we can change the level of logging,
how to react to certain errors, how much info to log etc in user
space.

We are upgrading our kernel software to 4.19 and we noticed that
pcieport_if.h is no longer in linux/ dir and that breaks compilation
of our AER kernel module. From the comment in commit, we are inferring
the reason for renaming this file to pci/pcie/pcieport_if.h is because
no one but code under PCI core is registering PCIe service drivers. If
you or the PCI subsystem maintainers have no objection, we'd like to
revert commit c37e627f9565368ed7bd1f3cf59a2d223ddba85a. Please let us
know your thoughts.

Thank you
Prasad

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: reverting c37e627f9565368ed7bd1f3cf59a2d223ddba85a
  2019-08-20  5:15 reverting c37e627f9565368ed7bd1f3cf59a2d223ddba85a Prasad Koya
@ 2019-08-20 10:02 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2019-08-20 10:02 UTC (permalink / raw)
  To: Prasad Koya; +Cc: fred, linux-pci

On Mon, Aug 19, 2019 at 10:15:08PM -0700, Prasad Koya wrote:
> hi Frederick
> 
> At Arista Networks, we have a service driver for AER as a loadable
> module. The reasons for having Arista's own module and not enabling
> in-built aer driver (CONFIG_PCIEAER) is for the reasons below:

And as long as that isn't upstream no one is going to care for it,
and most certainly not reverting useful kernel improvements for it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20  5:15 reverting c37e627f9565368ed7bd1f3cf59a2d223ddba85a Prasad Koya
2019-08-20 10:02 ` Christoph Hellwig

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org linux-pci@archiver.kernel.org
	public-inbox-index linux-pci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox