Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] PCI: dwc: Use dev_info() instead of dev_err()
@ 2019-08-23 15:16 Vidya Sagar
  2019-08-23 15:40 ` Lorenzo Pieralisi
  2019-08-25 15:26 ` Jon Hunter
  0 siblings, 2 replies; 3+ messages in thread
From: Vidya Sagar @ 2019-08-23 15:16 UTC (permalink / raw)
  To: gustavo.pimentel, lorenzo.pieralisi, bhelgaas, thierry.reding, jonathanh
  Cc: linux-pci, linux-kernel, kthota, mmaddireddy, vidyas, sagar.tv

When a platform has an open PCIe slot, not having a device connected to
it doesn't have to result in a dev_err() print saying that the link is
not up but a dev_info() would suffice.

Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
 drivers/pci/controller/dwc/pcie-designware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index 59eaeeb21dbe..4d6690b6ca36 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
 		usleep_range(LINK_WAIT_USLEEP_MIN, LINK_WAIT_USLEEP_MAX);
 	}
 
-	dev_err(pci->dev, "Phy link never came up\n");
+	dev_info(pci->dev, "Phy link never came up\n");
 
 	return -ETIMEDOUT;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: dwc: Use dev_info() instead of dev_err()
  2019-08-23 15:16 [PATCH] PCI: dwc: Use dev_info() instead of dev_err() Vidya Sagar
@ 2019-08-23 15:40 ` Lorenzo Pieralisi
  2019-08-25 15:26 ` Jon Hunter
  1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2019-08-23 15:40 UTC (permalink / raw)
  To: Vidya Sagar
  Cc: gustavo.pimentel, bhelgaas, thierry.reding, jonathanh, linux-pci,
	linux-kernel, kthota, mmaddireddy, sagar.tv

On Fri, Aug 23, 2019 at 08:46:18PM +0530, Vidya Sagar wrote:
> When a platform has an open PCIe slot, not having a device connected to
> it doesn't have to result in a dev_err() print saying that the link is
> not up but a dev_info() would suffice.
> 
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>  drivers/pci/controller/dwc/pcie-designware.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Squashed in pci/tegra, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 59eaeeb21dbe..4d6690b6ca36 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
>  		usleep_range(LINK_WAIT_USLEEP_MIN, LINK_WAIT_USLEEP_MAX);
>  	}
>  
> -	dev_err(pci->dev, "Phy link never came up\n");
> +	dev_info(pci->dev, "Phy link never came up\n");
>  
>  	return -ETIMEDOUT;
>  }
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: dwc: Use dev_info() instead of dev_err()
  2019-08-23 15:16 [PATCH] PCI: dwc: Use dev_info() instead of dev_err() Vidya Sagar
  2019-08-23 15:40 ` Lorenzo Pieralisi
@ 2019-08-25 15:26 ` Jon Hunter
  1 sibling, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2019-08-25 15:26 UTC (permalink / raw)
  To: Vidya Sagar, gustavo.pimentel, lorenzo.pieralisi, bhelgaas,
	thierry.reding
  Cc: linux-pci, linux-kernel, kthota, mmaddireddy, sagar.tv


On 23/08/2019 16:16, Vidya Sagar wrote:
> When a platform has an open PCIe slot, not having a device connected to
> it doesn't have to result in a dev_err() print saying that the link is
> not up but a dev_info() would suffice.
> 
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>  drivers/pci/controller/dwc/pcie-designware.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 59eaeeb21dbe..4d6690b6ca36 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
>  		usleep_range(LINK_WAIT_USLEEP_MIN, LINK_WAIT_USLEEP_MAX);
>  	}
>  
> -	dev_err(pci->dev, "Phy link never came up\n");
> +	dev_info(pci->dev, "Phy link never came up\n");

IMO this message is not very descriptive. Why not just say 'no device
connected'? From the changelog it is clear what this means but the
message itself could be clearer. Or should it even be a dev_dbg?

Cheers
Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 15:16 [PATCH] PCI: dwc: Use dev_info() instead of dev_err() Vidya Sagar
2019-08-23 15:40 ` Lorenzo Pieralisi
2019-08-25 15:26 ` Jon Hunter

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org linux-pci@archiver.kernel.org
	public-inbox-index linux-pci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox