Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
From: Yurii Monakov <monakov.y@gmail.com>
To: linux-pci@vger.kernel.org
Cc: m-karicheri2@ti.com
Subject: [PATCH] PCI: keystone: Fix outbound region mapping
Date: Fri, 4 Oct 2019 18:48:11 +0300
Message-ID: <20191004154811.GA31397@monakov-y.office.kontur-niirs.ru> (raw)

PCIe window memory start address should be incremented by OB_WIN_SIZE
megabytes (8 MB) instead of plain OB_WIN_SIZE (8).

Signed-off-by: Yurii Monakov <monakov.y@gmail.com>
---
 drivers/pci/controller/dwc/pci-keystone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
index af677254a072..f19de60ac991 100644
--- a/drivers/pci/controller/dwc/pci-keystone.c
+++ b/drivers/pci/controller/dwc/pci-keystone.c
@@ -422,7 +422,7 @@ static void ks_pcie_setup_rc_app_regs(struct keystone_pcie *ks_pcie)
 				   lower_32_bits(start) | OB_ENABLEN);
 		ks_pcie_app_writel(ks_pcie, OB_OFFSET_HI(i),
 				   upper_32_bits(start));
-		start += OB_WIN_SIZE;
+		start += OB_WIN_SIZE * SZ_1M;
 	}
 
 	val = ks_pcie_app_readl(ks_pcie, CMD_STATUS);
-- 
2.17.1


             reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04 15:48 Yurii Monakov [this message]
2019-10-04 16:05 ` Andrew Murray
2019-10-04 16:37   ` Yurii Monakov
2019-12-16 12:03     ` Andrew Murray
2019-12-17 14:31 ` Bjorn Helgaas
2019-12-17 16:31   ` Yurii Monakov
2019-12-17 21:54     ` Bjorn Helgaas
2019-12-18 13:31       ` Yurii Monakov
2019-12-19 11:21         ` Kishon Vijay Abraham I
2020-01-10 17:33       ` Lorenzo Pieralisi
  -- strict thread matches above, loose matches on Subject: below --
2019-10-04 15:16 Yurii Monakov

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191004154811.GA31397@monakov-y.office.kontur-niirs.ru \
    --to=monakov.y@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org
	public-inbox-index linux-pci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git