From: Andrew Murray <andrew.murray@arm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Tom Joseph <tjoseph@cadence.com>,
linux-pci@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.
Date: Mon, 7 Oct 2019 14:56:37 +0100 [thread overview]
Message-ID: <20191007135636.GA42880@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191001214912.GA78523@google.com>
On Tue, Oct 01, 2019 at 04:49:12PM -0500, Bjorn Helgaas wrote:
> On Tue, Oct 01, 2019 at 11:07:28AM +0100, Andrew Murray wrote:
> > Hi Tom,
> >
> > Thanks for the patch.
> >
> > I'd suggest that you rename the subject of this series to "PCI: cadence: ..."
> > to be consistent with the existing commit history, e.g. git log
> > --oneline drivers/pci/controller/pcie-cadence* - you'll also see that you
> > don't need a full stop at the end, and you ought to also change the tense
> > of the subject, e.g. Refactor driver to ...
> >
> > See comments inline...
>
> Andrew, thank you very much for your detailed and thoughtful reviews
> here and elsewhere. It is a huge help.
>
Thanks no problem, it's a pleasure :)
Thanks,
Andrew Murray
> Bjorn
next prev parent reply other threads:[~2019-10-07 13:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 16:42 [PATCH] PCI:cadence:Driver refactored to use as a core library Tom Joseph
2019-10-01 10:07 ` Andrew Murray
2019-10-01 10:38 ` Kishon Vijay Abraham I
2019-10-01 10:40 ` Andrew Murray
2019-10-01 13:44 ` Tom Joseph
2019-10-01 21:49 ` Bjorn Helgaas
2019-10-07 13:56 ` Andrew Murray [this message]
2019-10-01 11:15 ` Kishon Vijay Abraham I
2019-10-15 11:23 ` Kishon Vijay Abraham I
2019-10-16 16:19 ` Tom Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007135636.GA42880@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).