From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tom Joseph <tjoseph@cadence.com>, <linux-pci@vger.kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.
Date: Tue, 15 Oct 2019 16:53:20 +0530 [thread overview]
Message-ID: <ba7cf838-dc20-2007-cbf4-e8fbcd49e69f@ti.com> (raw)
In-Reply-To: <03a8af4b-96bb-48b6-a79b-7db3a2ee59d0@ti.com>
Hi Tom,
On 01/10/19 4:45 PM, Kishon Vijay Abraham I wrote:
> Hi Tom,
>
> On 30/09/19 10:12 PM, Tom Joseph wrote:
>> All the platform related APIs/Structures in the driver has been extracted
>> out to a separate file (pcie-cadence-plat.c). This will enable the
>> driver to be used as a core library, which could be used by other
>> platform drivers.Testing was done using simulation environment.
>>
>> Signed-off-by: Tom Joseph <tjoseph@cadence.com>
>> ---
>> drivers/pci/controller/Kconfig | 35 +++++++
>> drivers/pci/controller/Makefile | 1 +
>> drivers/pci/controller/pcie-cadence-ep.c | 78 ++-------------
>> drivers/pci/controller/pcie-cadence-host.c | 77 +++------------
>> drivers/pci/controller/pcie-cadence-plat.c | 154 +++++++++++++++++++++++++++++
>> drivers/pci/controller/pcie-cadence.h | 69 +++++++++++++
>> 6 files changed, 278 insertions(+), 136 deletions(-)
>> create mode 100644 drivers/pci/controller/pcie-cadence-plat.c
>>
<snip>
>> diff --git a/drivers/pci/controller/pcie-cadence-plat.c b/drivers/pci/controller/pcie-cadence-plat.c
>> new file mode 100644
>> index 0000000..274615d
>> --- /dev/null
>> +++ b/drivers/pci/controller/pcie-cadence-plat.c
>> @@ -0,0 +1,154 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +// Copyright (c) 2019 Cadence
>> +// Cadence PCIe platform driver.
>> +// Author: Tom Joseph <tjoseph@cadence.com>
>> +
>> +#include <linux/kernel.h>
>> +#include <linux/of_address.h>
>> +#include <linux/of_pci.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/pm_runtime.h>
>> +#include <linux/of_device.h>
>> +#include "pcie-cadence.h"
>> +
>> +/**
>> + * struct cdns_plat_pcie - private data for this PCIe platform driver
>> + * @pcie: Cadence PCIe controller
>> + * @regmap: pointer to PCIe device
>> + * @is_rc: Set to 1 indicates the PCIe controller mode is Root Complex,
>> + * if 0 it is in Endpoint mode.
>> + */
>> +struct cdns_plat_pcie {
>> + struct cdns_pcie *pcie;
>> + bool is_rc;
>> +};
>> +
>> +struct cdns_plat_pcie_of_data {
>> + bool is_rc;
>> +};
>> +
>> +static const struct of_device_id cdns_plat_pcie_of_match[];
>> +
>> +int cdns_plat_pcie_link_control(struct cdns_pcie *pcie, bool start)
>> +{
>> + pr_debug(" %s called\n", __func__);
>> + return 0;
>> +}
>> +
>> +bool cdns_plat_pcie_link_status(struct cdns_pcie *pcie)
How do you get cdns_plat_pcie from pcie? Cadence plat doesn't need it however
the platform specific base address will be stored in the platform specific
structure (struct cdns_plat_pcie here) which will be used for performing
controller configuration.
I think you can just move *dev to struct cdns_pcie from struct
cdns_pcie_ep/struct cdns_pcie_rc and use dev_get_drvdata here to get platform
specific structure.
Thanks
Kishon
next prev parent reply other threads:[~2019-10-15 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 16:42 [PATCH] PCI:cadence:Driver refactored to use as a core library Tom Joseph
2019-10-01 10:07 ` Andrew Murray
2019-10-01 10:38 ` Kishon Vijay Abraham I
2019-10-01 10:40 ` Andrew Murray
2019-10-01 13:44 ` Tom Joseph
2019-10-01 21:49 ` Bjorn Helgaas
2019-10-07 13:56 ` Andrew Murray
2019-10-01 11:15 ` Kishon Vijay Abraham I
2019-10-15 11:23 ` Kishon Vijay Abraham I [this message]
2019-10-16 16:19 ` Tom Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba7cf838-dc20-2007-cbf4-e8fbcd49e69f@ti.com \
--to=kishon@ti.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).