From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Logan Gunthorpe <logang@deltatee.com>
Subject: Re: [PATCH v1 2/3] PCI: Change pci_bus_distribute_available_resources() args to struct resource
Date: Mon, 13 Jan 2020 16:15:33 +0200 [thread overview]
Message-ID: <20200113141533.GJ2838@lahna.fi.intel.com> (raw)
In-Reply-To: <PSXP216MB0438587C47CBEDF365B1EA27803C0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
On Mon, Jan 06, 2020 at 03:45:52PM +0000, Nicholas Johnson wrote:
> Change pci_bus_distribute_available_resources() arguments from
> resource_size_t to struct resource to add more information required to
> get the alignment correct for bridge windows with alignment >1M.
>
> We require (size, alignment), instead of just (size) which is what is
> currently available. The change from resource_size_t to struct resource
> does just that.
>
> Note that the struct resource arguments are passed by value and not by
> reference. We do not want to pass by reference and change the resource
> size of the parent bridge window. We only want the size information.
>
> No functional changes.
>
> Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2020-01-13 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:45 [PATCH v1 2/3] PCI: Change pci_bus_distribute_available_resources() args to struct resource Nicholas Johnson
2020-01-13 14:15 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113141533.GJ2838@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).