* [PATCH v1 1/4] PCI: In extend_bridge_window() change available to new_size
@ 2020-01-06 15:47 Nicholas Johnson
2020-01-13 16:10 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Johnson @ 2020-01-06 15:47 UTC (permalink / raw)
To: linux-kernel
Cc: linux-pci, Bjorn Helgaas, Mika Westerberg,
Benjamin Herrenschmidt, Logan Gunthorpe, Nicholas Johnson
In extend_bridge_window() change "available" parameter name to new_size.
This makes more sense as this parameter represents the new size for the
window.
Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
---
drivers/pci/setup-bus.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 8b39b9ebb..ed5055ef7 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -1834,14 +1834,14 @@ void __init pci_assign_unassigned_resources(void)
static void extend_bridge_window(struct pci_dev *bridge, struct resource *res,
struct list_head *add_list,
- resource_size_t available)
+ resource_size_t new_size)
{
struct pci_dev_resource *dev_res;
if (res->parent)
return;
- if (resource_size(res) >= available)
+ if (resource_size(res) >= new_size)
return;
dev_res = res_to_dev_res(add_list, res);
@@ -1849,10 +1849,10 @@ static void extend_bridge_window(struct pci_dev *bridge, struct resource *res,
return;
/* Is there room to extend the window? */
- if (available - resource_size(res) <= dev_res->add_size)
+ if (new_size - resource_size(res) <= dev_res->add_size)
return;
- dev_res->add_size = available - resource_size(res);
+ dev_res->add_size = new_size - resource_size(res);
pci_dbg(bridge, "bridge window %pR extended by %pa\n", res,
&dev_res->add_size);
}
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/4] PCI: In extend_bridge_window() change available to new_size
2020-01-06 15:47 [PATCH v1 1/4] PCI: In extend_bridge_window() change available to new_size Nicholas Johnson
@ 2020-01-13 16:10 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2020-01-13 16:10 UTC (permalink / raw)
To: Nicholas Johnson
Cc: linux-kernel, linux-pci, Bjorn Helgaas, Benjamin Herrenschmidt,
Logan Gunthorpe
On Mon, Jan 06, 2020 at 03:47:05PM +0000, Nicholas Johnson wrote:
> In extend_bridge_window() change "available" parameter name to new_size.
> This makes more sense as this parameter represents the new size for the
> window.
>
> Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-13 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 15:47 [PATCH v1 1/4] PCI: In extend_bridge_window() change available to new_size Nicholas Johnson
2020-01-13 16:10 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).