linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] PCI: Fix potential deadlock problems
@ 2020-02-05  9:17 Yicong Yang
  2020-02-05 17:30 ` Bjorn Helgaas
  0 siblings, 1 reply; 2+ messages in thread
From: Yicong Yang @ 2020-02-05  9:17 UTC (permalink / raw)
  To: helgaas, linux-pci; +Cc: f.fangjian, huangdaode

Currently we use several locks to avoid racing conditions in pci
framework. When involving more than one lock, the inconsistent
lock order will lead to deadlock problems. This patchset aims to
solve the problem by keeping the same lock order in different
processes.

Patch_1: fix the potential deadlock caused by pci_dev_lock() and
VF enable routine.
Patch_2: fix the deadlock caused by AER and sriov enable routine
as reported.

Yicong Yang (2):
  PCI: Change lock order in pci_dev_lock()
  PCI/AER: Fix deadlock triggered by AER and sriov enable routine

 drivers/pci/bus.c      |  8 ++++++++
 drivers/pci/pci.c      | 15 ++++++++-------
 drivers/pci/pci.h      |  4 ++++
 drivers/pci/pcie/err.c | 18 +++++-------------
 4 files changed, 25 insertions(+), 20 deletions(-)

--
2.8.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 0/2] PCI: Fix potential deadlock problems
  2020-02-05  9:17 [PATCH 0/2] PCI: Fix potential deadlock problems Yicong Yang
@ 2020-02-05 17:30 ` Bjorn Helgaas
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2020-02-05 17:30 UTC (permalink / raw)
  To: Yicong Yang; +Cc: linux-pci, f.fangjian, huangdaode

On Wed, Feb 05, 2020 at 05:17:57PM +0800, Yicong Yang wrote:
> Currently we use several locks to avoid racing conditions in pci
> framework. When involving more than one lock, the inconsistent
> lock order will lead to deadlock problems. This patchset aims to
> solve the problem by keeping the same lock order in different
> processes.
> 
> Patch_1: fix the potential deadlock caused by pci_dev_lock() and
> VF enable routine.
> Patch_2: fix the deadlock caused by AER and sriov enable routine
> as reported.

If it's possible for you to send these with the patches as responses
to the cover letter (as you did for the Jan 15 link speed patches),
the tools will work better, e.g., patchwork will notice that they all
belong together.

No need to resend this series for that reason, just FYI for the
future.

> Yicong Yang (2):
>   PCI: Change lock order in pci_dev_lock()
>   PCI/AER: Fix deadlock triggered by AER and sriov enable routine
> 
>  drivers/pci/bus.c      |  8 ++++++++
>  drivers/pci/pci.c      | 15 ++++++++-------
>  drivers/pci/pci.h      |  4 ++++
>  drivers/pci/pcie/err.c | 18 +++++-------------
>  4 files changed, 25 insertions(+), 20 deletions(-)
> 
> --
> 2.8.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-05 17:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05  9:17 [PATCH 0/2] PCI: Fix potential deadlock problems Yicong Yang
2020-02-05 17:30 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).