[pci:pci/hotplug 2/3] drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared; did you mean 'to_ctrl'?

[pci:pci/hotplug 2/3] drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared; did you mean 'to_ctrl'?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2975 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
head:   c4e85e3f147644d222f7d2da21a812f8ff3b7cbc
commit: 8fe64774eb64d97900d4b0551b6cbedfe4358636 [2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled
config: sparc64-randconfig-a001-20200211 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 8fe64774eb64d97900d4b0551b6cbedfe4358636
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15:0,
                    from include/linux/pci.h:37,
                    from drivers/pci/hotplug/pciehp_hpc.c:21:
   drivers/pci/hotplug/pciehp_hpc.c: In function 'pcie_wait_for_presence':
>> drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared (first use in this function); did you mean 'to_ctrl'?
     ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
               ^
   include/linux/dev_printk.h:110:12: note: in definition of macro 'dev_info'
     _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
               ^~~
>> drivers/pci/hotplug/pciehp.h:40:2: note: in expansion of macro 'pci_info'
     pci_info(ctrl->pcie->port, format, ## arg)
     ^~~~~~~~
>> drivers/pci/hotplug/pciehp_hpc.c:268:2: note: in expansion of macro 'ctrl_info'
     ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
     ^~~~~~~~~
   drivers/pci/hotplug/pciehp_hpc.c:268:12: note: each undeclared identifier is reported only once for each function it appears in
     ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
               ^
   include/linux/dev_printk.h:110:12: note: in definition of macro 'dev_info'
     _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
               ^~~
>> drivers/pci/hotplug/pciehp.h:40:2: note: in expansion of macro 'pci_info'
     pci_info(ctrl->pcie->port, format, ## arg)
     ^~~~~~~~
>> drivers/pci/hotplug/pciehp_hpc.c:268:2: note: in expansion of macro 'ctrl_info'
     ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
     ^~~~~~~~~

vim +268 drivers/pci/hotplug/pciehp_hpc.c

   254	
   255	static void pcie_wait_for_presence(struct pci_dev *pdev)
   256	{
   257		int timeout = 1250;
   258		u16 slot_status;
   259	
   260		do {
   261			pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &slot_status);
   262			if (slot_status & PCI_EXP_SLTSTA_PDS)
   263				return;
   264			msleep(10);
   265			timeout -= 10;
   266		} while (timeout > 0);
   267	
 > 268		ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
   269	}
   270	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28930 bytes --]

Re: [pci:pci/hotplug 2/3] drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared; did you mean 'to_ctrl'?

[Bjorn Helgaas]

On Tue, Feb 11, 2020 at 02:04:54PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
> head:   c4e85e3f147644d222f7d2da21a812f8ff3b7cbc
> commit: 8fe64774eb64d97900d4b0551b6cbedfe4358636 [2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled
> config: sparc64-randconfig-a001-20200211 (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 8fe64774eb64d97900d4b0551b6cbedfe4358636
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=sparc64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/device.h:15:0,
>                     from include/linux/pci.h:37,
>                     from drivers/pci/hotplug/pciehp_hpc.c:21:
>    drivers/pci/hotplug/pciehp_hpc.c: In function 'pcie_wait_for_presence':
> >> drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared (first use in this function); did you mean 'to_ctrl'?
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>                ^
>    include/linux/dev_printk.h:110:12: note: in definition of macro 'dev_info'
>      _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
>                ^~~
> >> drivers/pci/hotplug/pciehp.h:40:2: note: in expansion of macro 'pci_info'
>      pci_info(ctrl->pcie->port, format, ## arg)
>      ^~~~~~~~
> >> drivers/pci/hotplug/pciehp_hpc.c:268:2: note: in expansion of macro 'ctrl_info'
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>      ^~~~~~~~~
>    drivers/pci/hotplug/pciehp_hpc.c:268:12: note: each undeclared identifier is reported only once for each function it appears in
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>                ^
>    include/linux/dev_printk.h:110:12: note: in definition of macro 'dev_info'
>      _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
>                ^~~
> >> drivers/pci/hotplug/pciehp.h:40:2: note: in expansion of macro 'pci_info'
>      pci_info(ctrl->pcie->port, format, ## arg)
>      ^~~~~~~~
> >> drivers/pci/hotplug/pciehp_hpc.c:268:2: note: in expansion of macro 'ctrl_info'
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>      ^~~~~~~~~

My fault, fixed.  Sorry, don't know what I was thinking.  Obviously
not much.