* Re: mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c) [not found] <62819368-150e-6b49-3ab3-9a2ab28481b3@infradead.org> @ 2020-03-24 16:18 ` Bjorn Helgaas 2020-03-25 15:13 ` Vidya Sagar 0 siblings, 1 reply; 6+ messages in thread From: Bjorn Helgaas @ 2020-03-24 16:18 UTC (permalink / raw) To: Randy Dunlap Cc: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, sfr, linux-pci, Vidya Sagar On Tue, Mar 24, 2020 at 08:16:34AM -0700, Randy Dunlap wrote: > On 3/23/20 9:30 PM, akpm@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2020-03-23-21-29 has been uploaded to > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > more than once a week. > > > > You will need quilt to apply these patches to the latest Linus release (5.x > > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in > > http://ozlabs.org/~akpm/mmotm/series > > > on x86_64: > > ../drivers/pci/controller/dwc/pcie-tegra194.c: In function ‘tegra_pcie_dw_parse_dt’: > ../drivers/pci/controller/dwc/pcie-tegra194.c:1160:24: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_phy_get’? [-Werror=implicit-function-declaration] > pcie->pex_rst_gpiod = devm_gpiod_get(pcie->dev, "reset", GPIOD_IN); > ^~~~~~~~~~~~~~ > devm_phy_get Thanks a lot for the report! This was found on mmotm, but I updated my -next branch with Lorenzo's latest pci/endpoint branch (current head 775d9e68f470) and reproduced this build failure with the .config you attached. I dropped that branch from my -next branch for now and pushed it. Bjorn ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c) 2020-03-24 16:18 ` mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c) Bjorn Helgaas @ 2020-03-25 15:13 ` Vidya Sagar 2020-03-25 15:52 ` Randy Dunlap 2020-03-25 17:01 ` Lorenzo Pieralisi 0 siblings, 2 replies; 6+ messages in thread From: Vidya Sagar @ 2020-03-25 15:13 UTC (permalink / raw) To: Bjorn Helgaas, Randy Dunlap, lorenzo.pieralisi Cc: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, sfr, linux-pci On 3/24/2020 9:48 PM, Bjorn Helgaas wrote: > External email: Use caution opening links or attachments > > > On Tue, Mar 24, 2020 at 08:16:34AM -0700, Randy Dunlap wrote: >> On 3/23/20 9:30 PM, akpm@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2020-03-23-21-29 has been uploaded to >>> >>> http://www.ozlabs.org/~akpm/mmotm/ >>> >>> mmotm-readme.txt says >>> >>> README for mm-of-the-moment: >>> >>> http://www.ozlabs.org/~akpm/mmotm/ >>> >>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully >>> more than once a week. >>> >>> You will need quilt to apply these patches to the latest Linus release (5.x >>> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in >>> http://ozlabs.org/~akpm/mmotm/series >> >> >> on x86_64: >> >> ../drivers/pci/controller/dwc/pcie-tegra194.c: In function ‘tegra_pcie_dw_parse_dt’: >> ../drivers/pci/controller/dwc/pcie-tegra194.c:1160:24: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_phy_get’? [-Werror=implicit-function-declaration] >> pcie->pex_rst_gpiod = devm_gpiod_get(pcie->dev, "reset", GPIOD_IN); >> ^~~~~~~~~~~~~~ >> devm_phy_get > > Thanks a lot for the report! > > This was found on mmotm, but I updated my -next branch with Lorenzo's > latest pci/endpoint branch (current head 775d9e68f470) and reproduced > this build failure with the .config you attached. > > I dropped that branch from my -next branch for now and pushed it. I found that one header file inclusion is missing. The following patch fixes it. Also, I wanted to know how can I catch this locally? i.e. How can I generate the config file attached by Randy locally so that I can get the source ready without these kind of issues? Bjorn/Lorenzo, would you be able to apply below change in your trees or do I need to send a patch for this? diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index 97d3f3db1020..eeeca18892c6 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -11,6 +11,7 @@ #include <linux/debugfs.h> #include <linux/delay.h> #include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/interrupt.h> #include <linux/iopoll.h> #include <linux/kernel.h> > > Bjorn > ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c) 2020-03-25 15:13 ` Vidya Sagar @ 2020-03-25 15:52 ` Randy Dunlap 2020-03-25 17:01 ` Lorenzo Pieralisi 1 sibling, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2020-03-25 15:52 UTC (permalink / raw) To: Vidya Sagar, Bjorn Helgaas, lorenzo.pieralisi Cc: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, sfr, linux-pci On 3/25/20 8:13 AM, Vidya Sagar wrote: > > > On 3/24/2020 9:48 PM, Bjorn Helgaas wrote: >> External email: Use caution opening links or attachments >> >> >> On Tue, Mar 24, 2020 at 08:16:34AM -0700, Randy Dunlap wrote: >>> On 3/23/20 9:30 PM, akpm@linux-foundation.org wrote: >>>> The mm-of-the-moment snapshot 2020-03-23-21-29 has been uploaded to >>>> >>>> http://www.ozlabs.org/~akpm/mmotm/ >>>> >>>> mmotm-readme.txt says >>>> >>>> README for mm-of-the-moment: >>>> >>>> http://www.ozlabs.org/~akpm/mmotm/ >>>> >>>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully >>>> more than once a week. >>>> >>>> You will need quilt to apply these patches to the latest Linus release (5.x >>>> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in >>>> http://ozlabs.org/~akpm/mmotm/series >>> >>> >>> on x86_64: >>> >>> ../drivers/pci/controller/dwc/pcie-tegra194.c: In function ‘tegra_pcie_dw_parse_dt’: >>> ../drivers/pci/controller/dwc/pcie-tegra194.c:1160:24: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_phy_get’? [-Werror=implicit-function-declaration] >>> pcie->pex_rst_gpiod = devm_gpiod_get(pcie->dev, "reset", GPIOD_IN); >>> ^~~~~~~~~~~~~~ >>> devm_phy_get >> >> Thanks a lot for the report! >> >> This was found on mmotm, but I updated my -next branch with Lorenzo's >> latest pci/endpoint branch (current head 775d9e68f470) and reproduced >> this build failure with the .config you attached. >> >> I dropped that branch from my -next branch for now and pushed it. > I found that one header file inclusion is missing. > The following patch fixes it. > Also, I wanted to know how can I catch this locally? i.e. How can I generate the config file attached by Randy locally so that I can get the source ready without these kind of issues? > > Bjorn/Lorenzo, would you be able to apply below change in your trees or do I need to send a patch for this? > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index 97d3f3db1020..eeeca18892c6 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -11,6 +11,7 @@ > #include <linux/debugfs.h> > #include <linux/delay.h> > #include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/interrupt.h> > #include <linux/iopoll.h> > #include <linux/kernel.h> Yes, that works/fixes the problem. Thanks. Acked-by: Randy Dunlap <rdunlap@infradead.org> -- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c) 2020-03-25 15:13 ` Vidya Sagar 2020-03-25 15:52 ` Randy Dunlap @ 2020-03-25 17:01 ` Lorenzo Pieralisi 2020-03-25 21:20 ` Bjorn Helgaas 1 sibling, 1 reply; 6+ messages in thread From: Lorenzo Pieralisi @ 2020-03-25 17:01 UTC (permalink / raw) To: Vidya Sagar Cc: Bjorn Helgaas, Randy Dunlap, akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, sfr, linux-pci On Wed, Mar 25, 2020 at 08:43:32PM +0530, Vidya Sagar wrote: > > > On 3/24/2020 9:48 PM, Bjorn Helgaas wrote: > > External email: Use caution opening links or attachments > > > > > > On Tue, Mar 24, 2020 at 08:16:34AM -0700, Randy Dunlap wrote: > > > On 3/23/20 9:30 PM, akpm@linux-foundation.org wrote: > > > > The mm-of-the-moment snapshot 2020-03-23-21-29 has been uploaded to > > > > > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > > > > > mmotm-readme.txt says > > > > > > > > README for mm-of-the-moment: > > > > > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > > > more than once a week. > > > > > > > > You will need quilt to apply these patches to the latest Linus release (5.x > > > > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in > > > > http://ozlabs.org/~akpm/mmotm/series > > > > > > > > > on x86_64: > > > > > > ../drivers/pci/controller/dwc/pcie-tegra194.c: In function ‘tegra_pcie_dw_parse_dt’: > > > ../drivers/pci/controller/dwc/pcie-tegra194.c:1160:24: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_phy_get’? [-Werror=implicit-function-declaration] > > > pcie->pex_rst_gpiod = devm_gpiod_get(pcie->dev, "reset", GPIOD_IN); > > > ^~~~~~~~~~~~~~ > > > devm_phy_get > > > > Thanks a lot for the report! > > > > This was found on mmotm, but I updated my -next branch with Lorenzo's > > latest pci/endpoint branch (current head 775d9e68f470) and reproduced > > this build failure with the .config you attached. > > > > I dropped that branch from my -next branch for now and pushed it. > I found that one header file inclusion is missing. > The following patch fixes it. > Also, I wanted to know how can I catch this locally? i.e. How can I > generate the config file attached by Randy locally so that I can get the > source ready without these kind of issues? > > Bjorn/Lorenzo, would you be able to apply below change in your trees or > do I need to send a patch for this? Squashed in and re-pushed out pci/endpoint, it should have fixed this issue. Thanks, Lorenzo > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c > b/drivers/pci/controller/dwc/pcie-tegra194.c > index 97d3f3db1020..eeeca18892c6 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -11,6 +11,7 @@ > #include <linux/debugfs.h> > #include <linux/delay.h> > #include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/interrupt.h> > #include <linux/iopoll.h> > #include <linux/kernel.h> > > > > > > Bjorn > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c) 2020-03-25 17:01 ` Lorenzo Pieralisi @ 2020-03-25 21:20 ` Bjorn Helgaas 2020-03-25 21:34 ` Randy Dunlap 0 siblings, 1 reply; 6+ messages in thread From: Bjorn Helgaas @ 2020-03-25 21:20 UTC (permalink / raw) To: Lorenzo Pieralisi Cc: Vidya Sagar, Randy Dunlap, akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, sfr, linux-pci On Wed, Mar 25, 2020 at 05:01:43PM +0000, Lorenzo Pieralisi wrote: > On Wed, Mar 25, 2020 at 08:43:32PM +0530, Vidya Sagar wrote: > > On 3/24/2020 9:48 PM, Bjorn Helgaas wrote: > > > On Tue, Mar 24, 2020 at 08:16:34AM -0700, Randy Dunlap wrote: > > > > On 3/23/20 9:30 PM, akpm@linux-foundation.org wrote: > > > > > The mm-of-the-moment snapshot 2020-03-23-21-29 has been uploaded to > > > > > > > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > > > > > > > mmotm-readme.txt says > > > > > > > > > > README for mm-of-the-moment: > > > > > > > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > > > > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > > > > more than once a week. > > > > > > > > > > You will need quilt to apply these patches to the latest Linus release (5.x > > > > > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in > > > > > http://ozlabs.org/~akpm/mmotm/series > > > > > > > > > > > > on x86_64: > > > > > > > > ../drivers/pci/controller/dwc/pcie-tegra194.c: In function ‘tegra_pcie_dw_parse_dt’: > > > > ../drivers/pci/controller/dwc/pcie-tegra194.c:1160:24: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_phy_get’? [-Werror=implicit-function-declaration] > > > > pcie->pex_rst_gpiod = devm_gpiod_get(pcie->dev, "reset", GPIOD_IN); > > > > ^~~~~~~~~~~~~~ > > > > devm_phy_get > > > > > > Thanks a lot for the report! > > > > > > This was found on mmotm, but I updated my -next branch with Lorenzo's > > > latest pci/endpoint branch (current head 775d9e68f470) and reproduced > > > this build failure with the .config you attached. > > > > > > I dropped that branch from my -next branch for now and pushed it. > > I found that one header file inclusion is missing. > > The following patch fixes it. > > Also, I wanted to know how can I catch this locally? i.e. How can I > > generate the config file attached by Randy locally so that I can get the > > source ready without these kind of issues? Randy attached the config-r1578 file to his initial report. I saved that attachment, then: $ git checkout next $ make mrproper $ cp ~/Downloads/config-r1578 .config $ make drivers/pci/controller/ > > Bjorn/Lorenzo, would you be able to apply below change in your trees or > > do I need to send a patch for this? > > Squashed in and re-pushed out pci/endpoint, it should have fixed this > issue. I updated my -next branch with this, thanks! Bjorn ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c) 2020-03-25 21:20 ` Bjorn Helgaas @ 2020-03-25 21:34 ` Randy Dunlap 0 siblings, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2020-03-25 21:34 UTC (permalink / raw) To: Bjorn Helgaas, Lorenzo Pieralisi Cc: Vidya Sagar, akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next, mhocko, mm-commits, sfr, linux-pci On 3/25/20 2:20 PM, Bjorn Helgaas wrote: > On Wed, Mar 25, 2020 at 05:01:43PM +0000, Lorenzo Pieralisi wrote: >> On Wed, Mar 25, 2020 at 08:43:32PM +0530, Vidya Sagar wrote: >>> Also, I wanted to know how can I catch this locally? i.e. How can I >>> generate the config file attached by Randy locally so that I can get the >>> source ready without these kind of issues? > > Randy attached the config-r1578 file to his initial report. I saved > that attachment, then: > > $ git checkout next > $ make mrproper > $ cp ~/Downloads/config-r1578 .config > $ make drivers/pci/controller/ Hi Vidya, All I do is run 20 of these on each linux-next and mmotm release: $ make clean; make randconfig; make all and see what happens. -- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-25 21:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <62819368-150e-6b49-3ab3-9a2ab28481b3@infradead.org>
2020-03-24 16:18 ` mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c) Bjorn Helgaas
2020-03-25 15:13 ` Vidya Sagar
2020-03-25 15:52 ` Randy Dunlap
2020-03-25 17:01 ` Lorenzo Pieralisi
2020-03-25 21:20 ` Bjorn Helgaas
2020-03-25 21:34 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).