linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] PCI: Don't select Kconfig symbols by default
@ 2020-04-15  0:12 Bjorn Helgaas
  2020-04-15  0:12 ` [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST " Bjorn Helgaas
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Bjorn Helgaas @ 2020-04-15  0:12 UTC (permalink / raw)
  To: linux-pci; +Cc: linux-kernel, Bjorn Helgaas

From: Bjorn Helgaas <bhelgaas@google.com>

A few Kconfig symbols snuck in with "default y".  In general we don't want
that because we don't want to bloat the kernel with unnecessary drivers.

Remove the ones that are optional.

There are a few left, but they depend on something else that seems like the
real choice, e.g., XEN_PCIDEV_FRONTEND depends on XEN and PCI_XGENE_MSI
depends on PCI_XGENE.

Bjorn Helgaas (4):
  PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
  PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST by default
  PCI/AER: Don't select CONFIG_PCIEAER by default
  PCI/ASPM: Don't select CONFIG_PCIEASPM by default

 drivers/pci/controller/dwc/Kconfig | 2 --
 drivers/pci/pcie/Kconfig           | 2 --
 2 files changed, 4 deletions(-)

-- 
2.26.0.110.g2183baf09c-goog


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
  2020-04-15  0:12 [PATCH 0/4] PCI: Don't select Kconfig symbols by default Bjorn Helgaas
@ 2020-04-15  0:12 ` Bjorn Helgaas
  2020-04-22 19:29   ` Rob Herring
  2020-04-15  0:12 ` [PATCH 2/4] PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST " Bjorn Helgaas
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Bjorn Helgaas @ 2020-04-15  0:12 UTC (permalink / raw)
  To: linux-pci; +Cc: linux-kernel, Bjorn Helgaas, Kishon Vijay Abraham I, linux-omap

From: Bjorn Helgaas <bhelgaas@google.com>

Drivers should not be selected by default because that bloats the kernel
for people who don't need them.

Remove the "default y" for CONFIG_PCI_DRA7XX_HOST.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-omap@vger.kernel.org
---
 drivers/pci/controller/dwc/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 03dcaf65d159..ea335ee7ca8e 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST
 	depends on OF && HAS_IOMEM && TI_PIPE3
 	select PCIE_DW_HOST
 	select PCI_DRA7XX
-	default y
 	help
 	  Enables support for the PCIe controller in the DRA7xx SoC to work in
 	  host mode. There are two instances of PCIe controller in DRA7xx.
-- 
2.26.0.110.g2183baf09c-goog


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 2/4] PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST by default
  2020-04-15  0:12 [PATCH 0/4] PCI: Don't select Kconfig symbols by default Bjorn Helgaas
  2020-04-15  0:12 ` [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST " Bjorn Helgaas
@ 2020-04-15  0:12 ` Bjorn Helgaas
  2020-04-15  0:12 ` [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER " Bjorn Helgaas
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 10+ messages in thread
From: Bjorn Helgaas @ 2020-04-15  0:12 UTC (permalink / raw)
  To: linux-pci; +Cc: linux-kernel, Bjorn Helgaas, Murali Karicheri, linux-arm-kernel

From: Bjorn Helgaas <bhelgaas@google.com>

Drivers should not be selected by default because that bloats the kernel
for people who don't need them.

Remove the "default y" for CONFIG_PCI_KEYSTONE_HOST.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Murali Karicheri <m-karicheri2@ti.com>
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/pci/controller/dwc/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index ea335ee7ca8e..695f754b2110 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -110,7 +110,6 @@ config PCI_KEYSTONE_HOST
 	depends on PCI_MSI_IRQ_DOMAIN
 	select PCIE_DW_HOST
 	select PCI_KEYSTONE
-	default y
 	help
 	  Enables support for the PCIe controller in the Keystone SoC to
 	  work in host mode. The PCI controller on Keystone is based on
-- 
2.26.0.110.g2183baf09c-goog


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER by default
  2020-04-15  0:12 [PATCH 0/4] PCI: Don't select Kconfig symbols by default Bjorn Helgaas
  2020-04-15  0:12 ` [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST " Bjorn Helgaas
  2020-04-15  0:12 ` [PATCH 2/4] PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST " Bjorn Helgaas
@ 2020-04-15  0:12 ` Bjorn Helgaas
  2020-04-15  0:20   ` Kuppuswamy, Sathyanarayanan
  2020-04-15  0:12 ` [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM " Bjorn Helgaas
  2020-04-24 19:37 ` [PATCH 0/4] PCI: Don't select Kconfig symbols " Bjorn Helgaas
  4 siblings, 1 reply; 10+ messages in thread
From: Bjorn Helgaas @ 2020-04-15  0:12 UTC (permalink / raw)
  To: linux-pci
  Cc: linux-kernel, Bjorn Helgaas, Russell Currey, Sam Bobroff,
	Oliver O'Halloran, Kuppuswamy Sathyanarayanan

From: Bjorn Helgaas <bhelgaas@google.com>

PCIe Advanced Error Reporting (AER) is optional and there's no need for it
to be selected by default.

Remove the "default y" for CONFIG_PCIEAER.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Russell Currey <ruscur@russell.cc>
Cc: Sam Bobroff <sbobroff@linux.ibm.com>
Cc: Oliver O'Halloran <oohall@gmail.com>
Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
 drivers/pci/pcie/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index 66386811cfde..9cd31331aee9 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -25,7 +25,6 @@ config PCIEAER
 	bool "PCI Express Advanced Error Reporting support"
 	depends on PCIEPORTBUS
 	select RAS
-	default y
 	help
 	  This enables PCI Express Root Port Advanced Error Reporting
 	  (AER) driver support. Error reporting messages sent to Root
-- 
2.26.0.110.g2183baf09c-goog


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM by default
  2020-04-15  0:12 [PATCH 0/4] PCI: Don't select Kconfig symbols by default Bjorn Helgaas
                   ` (2 preceding siblings ...)
  2020-04-15  0:12 ` [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER " Bjorn Helgaas
@ 2020-04-15  0:12 ` Bjorn Helgaas
  2020-06-01 16:31   ` Bjorn Helgaas
  2020-04-24 19:37 ` [PATCH 0/4] PCI: Don't select Kconfig symbols " Bjorn Helgaas
  4 siblings, 1 reply; 10+ messages in thread
From: Bjorn Helgaas @ 2020-04-15  0:12 UTC (permalink / raw)
  To: linux-pci; +Cc: linux-kernel, Bjorn Helgaas, Heiner Kallweit

From: Bjorn Helgaas <bhelgaas@google.com>

PCIe Active State Power Management (ASPM) is optional and there's no need
for it to be selected by default.

Remove the "default y" for CONFIG_PCIEASPM.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/pci/pcie/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index 9cd31331aee9..5b7b460a8a98 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -62,7 +62,6 @@ config PCIE_ECRC
 #
 config PCIEASPM
 	bool "PCI Express ASPM control" if EXPERT
-	default y
 	help
 	  This enables OS control over PCI Express ASPM (Active State
 	  Power Management) and Clock Power Management. ASPM supports
-- 
2.26.0.110.g2183baf09c-goog


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER by default
  2020-04-15  0:12 ` [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER " Bjorn Helgaas
@ 2020-04-15  0:20   ` Kuppuswamy, Sathyanarayanan
  0 siblings, 0 replies; 10+ messages in thread
From: Kuppuswamy, Sathyanarayanan @ 2020-04-15  0:20 UTC (permalink / raw)
  To: Bjorn Helgaas, linux-pci
  Cc: linux-kernel, Bjorn Helgaas, Russell Currey, Sam Bobroff,
	Oliver O'Halloran

Hi,

On 4/14/20 5:12 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> PCIe Advanced Error Reporting (AER) is optional and there's no need for it
> to be selected by default.
> 
> Remove the "default y" for CONFIG_PCIEAER.
Makes sense.
Reviewed-by: Kuppuswamy Sathyanarayanan 
<sathyanarayanan.kuppuswamy@linux.intel.com>
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Russell Currey <ruscur@russell.cc>
> Cc: Sam Bobroff <sbobroff@linux.ibm.com>
> Cc: Oliver O'Halloran <oohall@gmail.com>
> Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> ---
>   drivers/pci/pcie/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index 66386811cfde..9cd31331aee9 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -25,7 +25,6 @@ config PCIEAER
>   	bool "PCI Express Advanced Error Reporting support"
>   	depends on PCIEPORTBUS
>   	select RAS
> -	default y
>   	help
>   	  This enables PCI Express Root Port Advanced Error Reporting
>   	  (AER) driver support. Error reporting messages sent to Root
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
  2020-04-15  0:12 ` [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST " Bjorn Helgaas
@ 2020-04-22 19:29   ` Rob Herring
  2020-04-24 19:30     ` Bjorn Helgaas
  0 siblings, 1 reply; 10+ messages in thread
From: Rob Herring @ 2020-04-22 19:29 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: linux-pci, linux-kernel, Bjorn Helgaas, Kishon Vijay Abraham I,
	linux-omap

On Tue, Apr 14, 2020 at 07:12:41PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Drivers should not be selected by default because that bloats the kernel
> for people who don't need them.
> 
> Remove the "default y" for CONFIG_PCI_DRA7XX_HOST.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: linux-omap@vger.kernel.org
> ---
>  drivers/pci/controller/dwc/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 03dcaf65d159..ea335ee7ca8e 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST
>  	depends on OF && HAS_IOMEM && TI_PIPE3
>  	select PCIE_DW_HOST
>  	select PCI_DRA7XX
> -	default y

Perhaps 'default y if SOC_DRA7XX'?

>  	help
>  	  Enables support for the PCIe controller in the DRA7xx SoC to work in
>  	  host mode. There are two instances of PCIe controller in DRA7xx.
> -- 
> 2.26.0.110.g2183baf09c-goog
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
  2020-04-22 19:29   ` Rob Herring
@ 2020-04-24 19:30     ` Bjorn Helgaas
  0 siblings, 0 replies; 10+ messages in thread
From: Bjorn Helgaas @ 2020-04-24 19:30 UTC (permalink / raw)
  To: Rob Herring; +Cc: linux-pci, linux-kernel, Kishon Vijay Abraham I, linux-omap

On Wed, Apr 22, 2020 at 02:29:57PM -0500, Rob Herring wrote:
> On Tue, Apr 14, 2020 at 07:12:41PM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> > 
> > Drivers should not be selected by default because that bloats the kernel
> > for people who don't need them.
> > 
> > Remove the "default y" for CONFIG_PCI_DRA7XX_HOST.
> > 
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Kishon Vijay Abraham I <kishon@ti.com>
> > Cc: linux-omap@vger.kernel.org
> > ---
> >  drivers/pci/controller/dwc/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 03dcaf65d159..ea335ee7ca8e 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST
> >  	depends on OF && HAS_IOMEM && TI_PIPE3
> >  	select PCIE_DW_HOST
> >  	select PCI_DRA7XX
> > -	default y
> 
> Perhaps 'default y if SOC_DRA7XX'?

Good idea, I did that.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 0/4] PCI: Don't select Kconfig symbols by default
  2020-04-15  0:12 [PATCH 0/4] PCI: Don't select Kconfig symbols by default Bjorn Helgaas
                   ` (3 preceding siblings ...)
  2020-04-15  0:12 ` [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM " Bjorn Helgaas
@ 2020-04-24 19:37 ` Bjorn Helgaas
  4 siblings, 0 replies; 10+ messages in thread
From: Bjorn Helgaas @ 2020-04-24 19:37 UTC (permalink / raw)
  To: linux-pci; +Cc: linux-kernel

On Tue, Apr 14, 2020 at 07:12:40PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> A few Kconfig symbols snuck in with "default y".  In general we don't want
> that because we don't want to bloat the kernel with unnecessary drivers.
> 
> Remove the ones that are optional.
> 
> There are a few left, but they depend on something else that seems like the
> real choice, e.g., XEN_PCIDEV_FRONTEND depends on XEN and PCI_XGENE_MSI
> depends on PCI_XGENE.
> 
> Bjorn Helgaas (4):
>   PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
>   PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST by default
>   PCI/AER: Don't select CONFIG_PCIEAER by default
>   PCI/ASPM: Don't select CONFIG_PCIEASPM by default
> 
>  drivers/pci/controller/dwc/Kconfig | 2 --
>  drivers/pci/pcie/Kconfig           | 2 --
>  2 files changed, 4 deletions(-)

Applied with Sathy's reviewed-by on the AER patch and the tweak Rob
suggested to the dra7xx one to pci/kconfig for v5.8.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM by default
  2020-04-15  0:12 ` [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM " Bjorn Helgaas
@ 2020-06-01 16:31   ` Bjorn Helgaas
  0 siblings, 0 replies; 10+ messages in thread
From: Bjorn Helgaas @ 2020-06-01 16:31 UTC (permalink / raw)
  To: linux-pci
  Cc: linux-kernel, Bjorn Helgaas, Heiner Kallweit, Matthew Garrett,
	Christoph Hellwig, Rafael J. Wysocki

On Tue, Apr 14, 2020 at 07:12:44PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> PCIe Active State Power Management (ASPM) is optional and there's no need
> for it to be selected by default.
> 
> Remove the "default y" for CONFIG_PCIEASPM.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>

I dropped this patch for now.

Without CONFIG_PCIEASPM, Linux doesn't request control of *any*
features via _OSC (see ACPI_PCIE_REQ_SUPPORT), which means we can't
use PCIe PME to resume from runtime suspend.

https://bugzilla.redhat.com/show_bug.cgi?id=638912
https://lore.kernel.org/r/2e1ee784-7493-284b-96f9-96b2e0c4b817@gmail.com

> ---
>  drivers/pci/pcie/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index 9cd31331aee9..5b7b460a8a98 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -62,7 +62,6 @@ config PCIE_ECRC
>  #
>  config PCIEASPM
>  	bool "PCI Express ASPM control" if EXPERT
> -	default y
>  	help
>  	  This enables OS control over PCI Express ASPM (Active State
>  	  Power Management) and Clock Power Management. ASPM supports
> -- 
> 2.26.0.110.g2183baf09c-goog
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-06-01 16:31 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15  0:12 [PATCH 0/4] PCI: Don't select Kconfig symbols by default Bjorn Helgaas
2020-04-15  0:12 ` [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST " Bjorn Helgaas
2020-04-22 19:29   ` Rob Herring
2020-04-24 19:30     ` Bjorn Helgaas
2020-04-15  0:12 ` [PATCH 2/4] PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST " Bjorn Helgaas
2020-04-15  0:12 ` [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER " Bjorn Helgaas
2020-04-15  0:20   ` Kuppuswamy, Sathyanarayanan
2020-04-15  0:12 ` [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM " Bjorn Helgaas
2020-06-01 16:31   ` Bjorn Helgaas
2020-04-24 19:37 ` [PATCH 0/4] PCI: Don't select Kconfig symbols " Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).