From: Bjorn Helgaas <helgaas@kernel.org>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Pierre Morel <pmorel@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [RFC 1/2] PCI/IOV: Introduce pci_iov_sysfs_link() function
Date: Wed, 6 May 2020 16:10:18 -0500 [thread overview]
Message-ID: <20200506211018.GA454697@bjorn-Precision-5520> (raw)
In-Reply-To: <20200506154139.90609-2-schnelle@linux.ibm.com>
On Wed, May 06, 2020 at 05:41:38PM +0200, Niklas Schnelle wrote:
> currently pci_iov_add_virtfn() scans the SR-IOV bars, adds the VF to the
> bus and also creates the sysfs links between the newly added VF and its
> parent PF.
s/currently/Currently/
s/bars/BARs/
> With pdev->no_vf_scan fencing off the entire pci_iov_add_virtfn() call
> s390 as the sole pdev->no_vf_scan user thus ends up missing these sysfs
> links which are required for example by QEMU/libvirt.
> Instead of duplicating the code introduce a new pci_iov_sysfs_link()
> function for establishing sysfs links.
This looks like two paragraphs missing the blank line between.
This whole thing is not "introducing" any new functionality; it's
"refactoring" to move existing functionality around and make it
callable separately.
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
With the fixes above and a few below:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pci/iov.c | 36 ++++++++++++++++++++++++------------
> include/linux/pci.h | 8 ++++++++
> 2 files changed, 32 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 4d1f392b05f9..d0ddf5f5484c 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -113,7 +113,6 @@ resource_size_t pci_iov_resource_size(struct pci_dev *dev, int resno)
> static void pci_read_vf_config_common(struct pci_dev *virtfn)
> {
> struct pci_dev *physfn = virtfn->physfn;
> -
> /*
> * Some config registers are the same across all associated VFs.
> * Read them once from VF0 so we can skip reading them from the
> @@ -133,12 +132,34 @@ static void pci_read_vf_config_common(struct pci_dev *virtfn)
> &physfn->sriov->subsystem_device);
> }
>
> +int pci_iov_sysfs_link(struct pci_dev *dev,
> + struct pci_dev *virtfn, int id)
> +{
> + int rc;
> + char buf[VIRTFN_ID_LEN];
Swap the order so these are declared in the order they're used below.
> + sprintf(buf, "virtfn%u", id);
> + rc = sysfs_create_link(&dev->dev.kobj, &virtfn->dev.kobj, buf);
> + if (rc)
> + goto failed;
> + rc = sysfs_create_link(&virtfn->dev.kobj, &dev->dev.kobj, "physfn");
> + if (rc)
> + goto failed1;
> +
> + kobject_uevent(&virtfn->dev.kobj, KOBJ_CHANGE);
> +
> + return 0;
Add a blank link here to separate the "success" return from the error
paths.
> +failed1:
> + sysfs_remove_link(&dev->dev.kobj, buf);
> +failed:
> + return rc;
> +}
> +
> int pci_iov_add_virtfn(struct pci_dev *dev, int id)
> {
> int i;
> int rc = -ENOMEM;
> u64 size;
> - char buf[VIRTFN_ID_LEN];
> struct pci_dev *virtfn;
> struct resource *res;
> struct pci_sriov *iov = dev->sriov;
> @@ -182,23 +203,14 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id)
> }
>
> pci_device_add(virtfn, virtfn->bus);
> -
> - sprintf(buf, "virtfn%u", id);
> - rc = sysfs_create_link(&dev->dev.kobj, &virtfn->dev.kobj, buf);
> + rc = pci_iov_sysfs_link(dev, virtfn, id);
> if (rc)
> goto failed1;
> - rc = sysfs_create_link(&virtfn->dev.kobj, &dev->dev.kobj, "physfn");
> - if (rc)
> - goto failed2;
> -
> - kobject_uevent(&virtfn->dev.kobj, KOBJ_CHANGE);
>
> pci_bus_add_device(virtfn);
>
> return 0;
>
> -failed2:
> - sysfs_remove_link(&dev->dev.kobj, buf);
> failed1:
> pci_stop_and_remove_bus_device(virtfn);
> pci_dev_put(dev);
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 83ce1cdf5676..e97d27ac350a 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -2048,6 +2048,8 @@ int pci_iov_virtfn_devfn(struct pci_dev *dev, int id);
>
> int pci_enable_sriov(struct pci_dev *dev, int nr_virtfn);
> void pci_disable_sriov(struct pci_dev *dev);
> +
> +int pci_iov_sysfs_link(struct pci_dev *dev, struct pci_dev *virtfn, int id);
> int pci_iov_add_virtfn(struct pci_dev *dev, int id);
> void pci_iov_remove_virtfn(struct pci_dev *dev, int id);
> int pci_num_vf(struct pci_dev *dev);
> @@ -2073,6 +2075,12 @@ static inline int pci_iov_virtfn_devfn(struct pci_dev *dev, int id)
> }
> static inline int pci_enable_sriov(struct pci_dev *dev, int nr_virtfn)
> { return -ENODEV; }
> +
> +static inline int pci_iov_sysfs_link(struct pci_dev *dev,
> + struct pci_dev *virtfn, int id)
Align the second line with the args in the first line, as the rest of
this file does.
> +{
> + return -ENODEV;
> +}
> static inline int pci_iov_add_virtfn(struct pci_dev *dev, int id)
> {
> return -ENOSYS;
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-05-06 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 15:41 [RFC 0/2] Enable PF-VF linking with pdev->no_vf_scan (s390) Niklas Schnelle
2020-05-06 15:41 ` [RFC 1/2] PCI/IOV: Introduce pci_iov_sysfs_link() function Niklas Schnelle
2020-05-06 21:10 ` Bjorn Helgaas [this message]
2020-05-07 7:48 ` Niklas Schnelle
2020-05-07 15:51 ` Bjorn Helgaas
2020-05-06 15:41 ` [RFC 2/2] s390/pci: create links between PFs and VFs Niklas Schnelle
2020-05-06 21:12 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506211018.GA454697@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).