From: Bjorn Helgaas <helgaas@kernel.org>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Pierre Morel <pmorel@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [RFC 1/2] PCI/IOV: Introduce pci_iov_sysfs_link() function
Date: Thu, 7 May 2020 10:51:32 -0500 [thread overview]
Message-ID: <20200507155132.GA6568@bjorn-Precision-5520> (raw)
In-Reply-To: <e62d9d62-528f-ac1a-671f-4da2d2e88641@linux.ibm.com>
On Thu, May 07, 2020 at 09:48:30AM +0200, Niklas Schnelle wrote:
> On 5/6/20 11:10 PM, Bjorn Helgaas wrote:
> > On Wed, May 06, 2020 at 05:41:38PM +0200, Niklas Schnelle wrote:
> >> currently pci_iov_add_virtfn() scans the SR-IOV bars, adds the VF to the
> >> bus and also creates the sysfs links between the newly added VF and its
> >> parent PF.
> >
> > s/currently/Currently/
> > s/bars/BARs/
> >
> >> With pdev->no_vf_scan fencing off the entire pci_iov_add_virtfn() call
> >> s390 as the sole pdev->no_vf_scan user thus ends up missing these sysfs
> >> links which are required for example by QEMU/libvirt.
> >> Instead of duplicating the code introduce a new pci_iov_sysfs_link()
> >> function for establishing sysfs links.
> >
> > This looks like two paragraphs missing the blank line between.
> >
> > This whole thing is not "introducing" any new functionality; it's
> > "refactoring" to move existing functionality around and make it
> > callable separately.
> You're right I'll keep it in the subject for easier reference
> if that's okay with you.
> >
> >> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> >
> > With the fixes above and a few below:
> >
> > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Thank you for the very quick and useful feedback.
> I've incorporated the changes and will resend with the PATCH prefix.
> If/when accepted what tree should the first patch go to?
I'd expect them both to go via the s390 tree so there's no dependency
between the PCI merge and the s390 merge.
> And yes I plan to let the second patch go via the s390 tree.
next prev parent reply other threads:[~2020-05-07 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 15:41 [RFC 0/2] Enable PF-VF linking with pdev->no_vf_scan (s390) Niklas Schnelle
2020-05-06 15:41 ` [RFC 1/2] PCI/IOV: Introduce pci_iov_sysfs_link() function Niklas Schnelle
2020-05-06 21:10 ` Bjorn Helgaas
2020-05-07 7:48 ` Niklas Schnelle
2020-05-07 15:51 ` Bjorn Helgaas [this message]
2020-05-06 15:41 ` [RFC 2/2] s390/pci: create links between PFs and VFs Niklas Schnelle
2020-05-06 21:12 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507155132.GA6568@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).