linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] pci: controller: cadence: fix wrong path in comment
@ 2020-06-19 15:11 Flavio Suligoi
  2020-06-19 19:31 ` Bjorn Helgaas
  0 siblings, 1 reply; 2+ messages in thread
From: Flavio Suligoi @ 2020-06-19 15:11 UTC (permalink / raw)
  To: Tom Joseph, Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas
  Cc: linux-pci, linux-kernel, Flavio Suligoi

All native pci drivers are in drivers/pci/controller,
but this comment still refers to the old pathname,
when all pci drivers were located directly under the
drivers/pci directory.

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
---
 drivers/pci/controller/cadence/pcie-cadence-ep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
index 1c15c8352125..2a48b34ff249 100644
--- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
+++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
@@ -276,7 +276,7 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx)
 	cdns_pcie_ep_assert_intx(ep, fn, intx, true);
 	/*
 	 * The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq()
-	 * from drivers/pci/dwc/pci-dra7xx.c
+	 * from drivers/pci/controller/dwc/pci-dra7xx.c
 	 */
 	mdelay(1);
 	cdns_pcie_ep_assert_intx(ep, fn, intx, false);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] pci: controller: cadence: fix wrong path in comment
  2020-06-19 15:11 [PATCH 1/1] pci: controller: cadence: fix wrong path in comment Flavio Suligoi
@ 2020-06-19 19:31 ` Bjorn Helgaas
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2020-06-19 19:31 UTC (permalink / raw)
  To: Flavio Suligoi
  Cc: Tom Joseph, Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas,
	linux-pci, linux-kernel

On Fri, Jun 19, 2020 at 05:11:34PM +0200, Flavio Suligoi wrote:
> All native pci drivers are in drivers/pci/controller,
> but this comment still refers to the old pathname,
> when all pci drivers were located directly under the
> drivers/pci directory.
> 
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> ---
>  drivers/pci/controller/cadence/pcie-cadence-ep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> index 1c15c8352125..2a48b34ff249 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> @@ -276,7 +276,7 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx)
>  	cdns_pcie_ep_assert_intx(ep, fn, intx, true);
>  	/*
>  	 * The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq()
> -	 * from drivers/pci/dwc/pci-dra7xx.c
> +	 * from drivers/pci/controller/dwc/pci-dra7xx.c

I think the function name by itself would be enough, so maybe we
should remove the filename completely.

>  	 */
>  	mdelay(1);
>  	cdns_pcie_ep_assert_intx(ep, fn, intx, false);
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-19 19:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19 15:11 [PATCH 1/1] pci: controller: cadence: fix wrong path in comment Flavio Suligoi
2020-06-19 19:31 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).