* [PATCH] PCI: cadence: Fix static checker warning
@ 2020-07-27 12:59 Kishon Vijay Abraham I
2020-07-27 15:14 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2020-07-27 12:59 UTC (permalink / raw)
To: Tom Joseph, Bjorn Helgaas, Rob Herring, Kishon Vijay Abraham I,
Lorenzo Pieralisi
Cc: Dan Carpenter, linux-pci
Fix the following static checker warning
drivers/pci/controller/cadence/pcie-cadence-host.c:322 cdns_pcie_host_map_dma_ranges()
warn: ignoring unreachable code.
Fixes: 82d8567259b1 ("PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
Hi Lorenzo,
If possible can you squash this patch to "PCI: cadence: Use "dma-ranges" instead of
"cdns,no-bar-match-nbits" property".
Thanks
Kishon
drivers/pci/controller/cadence/pcie-cadence-host.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/cadence/pcie-cadence-host.c b/drivers/pci/controller/cadence/pcie-cadence-host.c
index ba157278fb0f..8d86560196aa 100644
--- a/drivers/pci/controller/cadence/pcie-cadence-host.c
+++ b/drivers/pci/controller/cadence/pcie-cadence-host.c
@@ -321,9 +321,10 @@ static int cdns_pcie_host_map_dma_ranges(struct cdns_pcie_rc *rc)
resource_list_for_each_entry(entry, &bridge->dma_ranges) {
err = cdns_pcie_host_bar_config(rc, entry);
- if (err)
+ if (err) {
dev_err(dev, "Fail to configure IB using dma-ranges\n");
- return err;
+ return err;
+ }
}
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: cadence: Fix static checker warning
2020-07-27 12:59 [PATCH] PCI: cadence: Fix static checker warning Kishon Vijay Abraham I
@ 2020-07-27 15:14 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2020-07-27 15:14 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Tom Joseph, Bjorn Helgaas, Rob Herring, Dan Carpenter, linux-pci
On Mon, Jul 27, 2020 at 06:29:32PM +0530, Kishon Vijay Abraham I wrote:
> Fix the following static checker warning
>
> drivers/pci/controller/cadence/pcie-cadence-host.c:322 cdns_pcie_host_map_dma_ranges()
> warn: ignoring unreachable code.
>
> Fixes: 82d8567259b1 ("PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Hi Lorenzo,
>
> If possible can you squash this patch to "PCI: cadence: Use "dma-ranges" instead of
> "cdns,no-bar-match-nbits" property".
Done, thanks !
Lorenzo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-27 15:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 12:59 [PATCH] PCI: cadence: Fix static checker warning Kishon Vijay Abraham I
2020-07-27 15:14 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).