* [PATCH] pci: vc: Fix kerneldoc
@ 2020-07-28 17:10 Krzysztof Kozlowski
2020-07-28 17:23 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-28 17:10 UTC (permalink / raw)
To: Bjorn Helgaas, linux-pci, linux-kernel; +Cc: Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc):
drivers/pci/vc.c:188: warning: Excess function parameter 'name' description in 'pci_vc_do_save_buffer'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/pci/vc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
index 5486f8768c86..5fc59ac31145 100644
--- a/drivers/pci/vc.c
+++ b/drivers/pci/vc.c
@@ -172,7 +172,6 @@ static void pci_vc_enable(struct pci_dev *dev, int pos, int res)
* @dev: device
* @pos: starting position of VC capability (VC/VC9/MFVC)
* @save_state: buffer for save/restore
- * @name: for error message
* @save: if provided a buffer, this indicates what to do with it
*
* Walking Virtual Channel config space to size, save, or restore it
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pci: vc: Fix kerneldoc
2020-07-28 17:10 [PATCH] pci: vc: Fix kerneldoc Krzysztof Kozlowski
@ 2020-07-28 17:23 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2020-07-28 17:23 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Bjorn Helgaas, linux-pci, linux-kernel
Patch looks fine, but can you run "git log --oneline drivers/pci/vc.c"
and match the subject line style?
On Tue, Jul 28, 2020 at 07:10:45PM +0200, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
>
> drivers/pci/vc.c:188: warning: Excess function parameter 'name' description in 'pci_vc_do_save_buffer'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/pci/vc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
> index 5486f8768c86..5fc59ac31145 100644
> --- a/drivers/pci/vc.c
> +++ b/drivers/pci/vc.c
> @@ -172,7 +172,6 @@ static void pci_vc_enable(struct pci_dev *dev, int pos, int res)
> * @dev: device
> * @pos: starting position of VC capability (VC/VC9/MFVC)
> * @save_state: buffer for save/restore
> - * @name: for error message
> * @save: if provided a buffer, this indicates what to do with it
> *
> * Walking Virtual Channel config space to size, save, or restore it
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-28 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 17:10 [PATCH] pci: vc: Fix kerneldoc Krzysztof Kozlowski
2020-07-28 17:23 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).