* [PATCH v2 1/1] PCI: cadence-ep: Remove obsolete path from comment
@ 2020-06-23 7:48 Flavio Suligoi
2020-09-07 15:15 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Flavio Suligoi @ 2020-06-23 7:48 UTC (permalink / raw)
To: Tom Joseph, Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas
Cc: linux-pci, linux-kernel, Flavio Suligoi
This comment still refers to the old driver pathname,
when all PCI drivers were located directly under the
drivers/pci directory.
Anyway the function name itself is enough, so we can
remove the overabundant path reference.
Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
---
v1: - after the suggestion of Bjorn, remove the whole comment line related to
the wrong path
- add: Acked-by: Bjorn Helgaas <bhelgaas@google.com>
V2: - change the subject line according to the previous commits of the
same file
- remove wrong "Acked-by ..."
drivers/pci/controller/cadence/pcie-cadence-ep.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
index 1c15c8352125..690eefd328ea 100644
--- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
+++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
@@ -276,7 +276,6 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx)
cdns_pcie_ep_assert_intx(ep, fn, intx, true);
/*
* The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq()
- * from drivers/pci/dwc/pci-dra7xx.c
*/
mdelay(1);
cdns_pcie_ep_assert_intx(ep, fn, intx, false);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] PCI: cadence-ep: Remove obsolete path from comment
2020-06-23 7:48 [PATCH v2 1/1] PCI: cadence-ep: Remove obsolete path from comment Flavio Suligoi
@ 2020-09-07 15:15 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2020-09-07 15:15 UTC (permalink / raw)
To: Flavio Suligoi
Cc: Tom Joseph, Rob Herring, Bjorn Helgaas, linux-pci, linux-kernel
On Tue, Jun 23, 2020 at 09:48:51AM +0200, Flavio Suligoi wrote:
> This comment still refers to the old driver pathname,
> when all PCI drivers were located directly under the
> drivers/pci directory.
>
> Anyway the function name itself is enough, so we can
> remove the overabundant path reference.
>
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> ---
>
> v1: - after the suggestion of Bjorn, remove the whole comment line related to
> the wrong path
> - add: Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> V2: - change the subject line according to the previous commits of the
> same file
> - remove wrong "Acked-by ..."
>
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to pci/cadence, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> index 1c15c8352125..690eefd328ea 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> @@ -276,7 +276,6 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx)
> cdns_pcie_ep_assert_intx(ep, fn, intx, true);
> /*
> * The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq()
> - * from drivers/pci/dwc/pci-dra7xx.c
> */
> mdelay(1);
> cdns_pcie_ep_assert_intx(ep, fn, intx, false);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-07 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 7:48 [PATCH v2 1/1] PCI: cadence-ep: Remove obsolete path from comment Flavio Suligoi
2020-09-07 15:15 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).