* [PATCH -next] PCI: dwc: unexport dw_pcie_link_set_max_speed
@ 2020-09-09 13:42 YueHaibing
2020-09-10 13:54 ` Rob Herring
2020-09-10 19:34 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-09-09 13:42 UTC (permalink / raw)
To: jingoohan1, gustavo.pimentel, lorenzo.pieralisi, robh, bhelgaas
Cc: linux-pci, linux-kernel, YueHaibing
This function has been made static, which causes warning:
WARNING: modpost: "dw_pcie_link_set_max_speed" [vmlinux] is a static EXPORT_SYMBOL_GPL
Fixes: 3af45d34d30c ("PCI: dwc: Centralize link gen setting")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/pci/controller/dwc/pcie-designware.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index 4d105efb5722..3c3a4d1dbc0b 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -508,7 +508,6 @@ static void dw_pcie_link_set_max_speed(struct dw_pcie *pci, u32 link_gen)
dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCAP, cap | link_speed);
}
-EXPORT_SYMBOL_GPL(dw_pcie_link_set_max_speed);
static u8 dw_pcie_iatu_unroll_enabled(struct dw_pcie *pci)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] PCI: dwc: unexport dw_pcie_link_set_max_speed
2020-09-09 13:42 [PATCH -next] PCI: dwc: unexport dw_pcie_link_set_max_speed YueHaibing
@ 2020-09-10 13:54 ` Rob Herring
2020-09-10 19:34 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-09-10 13:54 UTC (permalink / raw)
To: YueHaibing
Cc: Jingoo Han, Gustavo Pimentel, Lorenzo Pieralisi, Bjorn Helgaas,
PCI, linux-kernel
On Wed, Sep 9, 2020 at 7:42 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> This function has been made static, which causes warning:
>
> WARNING: modpost: "dw_pcie_link_set_max_speed" [vmlinux] is a static EXPORT_SYMBOL_GPL
>
> Fixes: 3af45d34d30c ("PCI: dwc: Centralize link gen setting")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-designware.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks for fixing.
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] PCI: dwc: unexport dw_pcie_link_set_max_speed
2020-09-09 13:42 [PATCH -next] PCI: dwc: unexport dw_pcie_link_set_max_speed YueHaibing
2020-09-10 13:54 ` Rob Herring
@ 2020-09-10 19:34 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2020-09-10 19:34 UTC (permalink / raw)
To: YueHaibing
Cc: jingoohan1, gustavo.pimentel, lorenzo.pieralisi, robh, bhelgaas,
linux-pci, linux-kernel
On Wed, Sep 09, 2020 at 09:42:34PM +0800, YueHaibing wrote:
> This function has been made static, which causes warning:
>
> WARNING: modpost: "dw_pcie_link_set_max_speed" [vmlinux] is a static EXPORT_SYMBOL_GPL
>
> Fixes: 3af45d34d30c ("PCI: dwc: Centralize link gen setting")
This commit is still on Lorenzo's pci/dwc branch, so he should be able
to squash this fix in.
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-designware.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 4d105efb5722..3c3a4d1dbc0b 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -508,7 +508,6 @@ static void dw_pcie_link_set_max_speed(struct dw_pcie *pci, u32 link_gen)
> dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCAP, cap | link_speed);
>
> }
> -EXPORT_SYMBOL_GPL(dw_pcie_link_set_max_speed);
>
> static u8 dw_pcie_iatu_unroll_enabled(struct dw_pcie *pci)
> {
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-10 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 13:42 [PATCH -next] PCI: dwc: unexport dw_pcie_link_set_max_speed YueHaibing
2020-09-10 13:54 ` Rob Herring
2020-09-10 19:34 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).