From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Kai Heng Feng <kai.heng.feng@canonical.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Time to re-enable Runtime PM per default for PCI devcies?
Date: Tue, 29 Dec 2020 12:30:24 +0100 [thread overview]
Message-ID: <20201229113024.GA7615@wunner.de> (raw)
In-Reply-To: <20201117163817.GA1397220@bjorn-Precision-5520>
> On Tue, Nov 17, 2020 at 04:56:09PM +0100, Heiner Kallweit wrote:
> > With Runtime PM disabled e.g. the PHY on network devices may remain
> > powered up even with no cable plugged in, affecting battery lifetime
> > on mobile devices. Currently we have to rely on the respective distro
> > or user to enable Runtime PM via sysfs (echo auto > power/control).
> > Some devices work around this restriction by calling pm_runtime_allow
> > in their probe routine, even though that's not recommended by
> > https://www.kernel.org/doc/Documentation/power/pci.txt
> >
> > Disabling Runtime PM per default seems to be a big hammer, a quirk
> > for affected devices / systems may had been better. And we still
> > have the option to disable Runtime PM for selected devices via sysfs.
Removing the recommendation in pci.txt and allowing runtime PM in more
drivers by default seems sensible to me. Such an incremental approach
is less risky with regards to regressions than a big hammer. Heiner,
care to submit patches to that effect?
Thanks,
Lukas
prev parent reply other threads:[~2020-12-29 11:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 15:56 Time to re-enable Runtime PM per default for PCI devcies? Heiner Kallweit
2020-11-17 16:38 ` Bjorn Helgaas
2020-11-17 16:57 ` Rafael J. Wysocki
2020-12-26 15:26 ` Heiner Kallweit
2020-12-29 11:56 ` Kai-Heng Feng
2020-12-29 21:11 ` Heiner Kallweit
2020-12-30 22:56 ` Heiner Kallweit
2020-12-31 4:07 ` Lukas Wunner
2020-12-31 9:38 ` Heiner Kallweit
2020-12-31 9:52 ` Heiner Kallweit
2021-01-04 17:39 ` Lukas Wunner
2021-01-04 20:32 ` Heiner Kallweit
2020-12-29 11:30 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229113024.GA7615@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).