From: Heiner Kallweit <hkallweit1@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Time to re-enable Runtime PM per default for PCI devcies?
Date: Tue, 17 Nov 2020 16:56:09 +0100 [thread overview]
Message-ID: <79940973-b631-90f9-dbc4-9579c6000816@gmail.com> (raw)
More than 10 yrs ago Runtime PM was disabled per default by bb910a7040
("PCI/PM Runtime: Make runtime PM of PCI devices inactive by default").
Reason given: "avoid breakage on systems where ACPI-based wake-up is
known to fail for some devices"
Unfortunately the commit message doesn't mention any affected devices
or systems.
With Runtime PM disabled e.g. the PHY on network devices may remain
powered up even with no cable plugged in, affecting battery lifetime
on mobile devices. Currently we have to rely on the respective distro
or user to enable Runtime PM via sysfs (echo auto > power/control).
Some devices work around this restriction by calling pm_runtime_allow
in their probe routine, even though that's not recommended by
https://www.kernel.org/doc/Documentation/power/pci.txt
Disabling Runtime PM per default seems to be a big hammer, a quirk
for affected devices / systems may had been better. And we still
have the option to disable Runtime PM for selected devices via sysfs.
So, to cut a long story short: Wouldn't it be time to remove this
restriction?
next reply other threads:[~2020-11-17 15:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 15:56 Heiner Kallweit [this message]
2020-11-17 16:38 ` Time to re-enable Runtime PM per default for PCI devcies? Bjorn Helgaas
2020-11-17 16:57 ` Rafael J. Wysocki
2020-12-26 15:26 ` Heiner Kallweit
2020-12-29 11:56 ` Kai-Heng Feng
2020-12-29 21:11 ` Heiner Kallweit
2020-12-30 22:56 ` Heiner Kallweit
2020-12-31 4:07 ` Lukas Wunner
2020-12-31 9:38 ` Heiner Kallweit
2020-12-31 9:52 ` Heiner Kallweit
2021-01-04 17:39 ` Lukas Wunner
2021-01-04 20:32 ` Heiner Kallweit
2020-12-29 11:30 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79940973-b631-90f9-dbc4-9579c6000816@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).