* [PATCH] PCI: Delay after FLR of Intel DC P4510 NVMe
@ 2021-04-08 19:05 Raphael Norwitz
2021-04-09 16:46 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Raphael Norwitz @ 2021-04-08 19:05 UTC (permalink / raw)
To: bhelgaas
Cc: linux-pci, linux-kernel, alex.williamson, ameynarkhede03,
Raphael Norwitz, Alay Shah, Suresh Gumpula
Like the Intel DC P3700 NVMe, the Intel P4510 NVMe exhibits a timeout
failure when the driver tries to interact with the device to soon after
an FLR. The same reset quirk the P3700 uses also resolves the failure
for the P4510, so this change introduces the same reset quirk for the
P4510.
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Alay Shah <alay.shah@nutanix.com>
Signed-off-by: Suresh Gumpula <suresh.gumpula@nutanix.com>
Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
---
drivers/pci/quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 653660e3ba9e..5a8c059b848d 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3922,6 +3922,7 @@ static const struct pci_dev_reset_methods pci_dev_reset_methods[] = {
reset_ivb_igd },
{ PCI_VENDOR_ID_SAMSUNG, 0xa804, nvme_disable_and_flr },
{ PCI_VENDOR_ID_INTEL, 0x0953, delay_250ms_after_flr },
+ { PCI_VENDOR_ID_INTEL, 0x0a54, delay_250ms_after_flr },
{ PCI_VENDOR_ID_CHELSIO, PCI_ANY_ID,
reset_chelsio_generic_dev },
{ 0 }
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: Delay after FLR of Intel DC P4510 NVMe
2021-04-08 19:05 [PATCH] PCI: Delay after FLR of Intel DC P4510 NVMe Raphael Norwitz
@ 2021-04-09 16:46 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2021-04-09 16:46 UTC (permalink / raw)
To: Raphael Norwitz
Cc: bhelgaas, linux-pci, linux-kernel, alex.williamson,
ameynarkhede03, Alay Shah, Suresh Gumpula
On Thu, Apr 08, 2021 at 07:05:27PM +0000, Raphael Norwitz wrote:
> Like the Intel DC P3700 NVMe, the Intel P4510 NVMe exhibits a timeout
> failure when the driver tries to interact with the device to soon after
> an FLR. The same reset quirk the P3700 uses also resolves the failure
> for the P4510, so this change introduces the same reset quirk for the
> P4510.
>
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Alay Shah <alay.shah@nutanix.com>
> Signed-off-by: Suresh Gumpula <suresh.gumpula@nutanix.com>
> Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Applied to pci/virtualization for v5.13, thanks!
> ---
> drivers/pci/quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 653660e3ba9e..5a8c059b848d 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3922,6 +3922,7 @@ static const struct pci_dev_reset_methods pci_dev_reset_methods[] = {
> reset_ivb_igd },
> { PCI_VENDOR_ID_SAMSUNG, 0xa804, nvme_disable_and_flr },
> { PCI_VENDOR_ID_INTEL, 0x0953, delay_250ms_after_flr },
> + { PCI_VENDOR_ID_INTEL, 0x0a54, delay_250ms_after_flr },
> { PCI_VENDOR_ID_CHELSIO, PCI_ANY_ID,
> reset_chelsio_generic_dev },
> { 0 }
> --
> 2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-09 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 19:05 [PATCH] PCI: Delay after FLR of Intel DC P4510 NVMe Raphael Norwitz
2021-04-09 16:46 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).