* [PATCH -next] PCI: remove unused variable rdev
@ 2021-04-17 11:42 Bixuan Cui
2021-04-17 20:36 ` Chaitanya Kulkarni
0 siblings, 1 reply; 2+ messages in thread
From: Bixuan Cui @ 2021-04-17 11:42 UTC (permalink / raw)
To: bhelgaas
Cc: alexander.deucher, Prike.Liang, chaitanya.kulkarni,
Shyam-sundar.S-k, linux-pci, linux-kernel
Fix the build warning:
drivers/pci/quirks.c: In function ‘quirk_amd_nvme_fixup’:
drivers/pci/quirks.c:312:18: warning: unused variable ‘rdev’ [-Wunused-variable]
struct pci_dev *rdev;
^~~~
Fixes: 9597624ef606 ('nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path')
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
drivers/pci/quirks.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 2e24dced699a..c86ede081534 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -309,8 +309,6 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8151_0, quirk_nopci
static void quirk_amd_nvme_fixup(struct pci_dev *dev)
{
- struct pci_dev *rdev;
-
dev->dev_flags |= PCI_DEV_FLAGS_AMD_NVME_SIMPLE_SUSPEND;
pci_info(dev, "AMD simple suspend opt enabled\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] PCI: remove unused variable rdev
2021-04-17 11:42 [PATCH -next] PCI: remove unused variable rdev Bixuan Cui
@ 2021-04-17 20:36 ` Chaitanya Kulkarni
0 siblings, 0 replies; 2+ messages in thread
From: Chaitanya Kulkarni @ 2021-04-17 20:36 UTC (permalink / raw)
To: Bixuan Cui, bhelgaas
Cc: alexander.deucher, Prike.Liang, Shyam-sundar.S-k, linux-pci,
linux-kernel
On 4/17/21 04:44, Bixuan Cui wrote:
> Fix the build warning:
>
> drivers/pci/quirks.c: In function ‘quirk_amd_nvme_fixup’:
> drivers/pci/quirks.c:312:18: warning: unused variable ‘rdev’ [-Wunused-variable]
> struct pci_dev *rdev;
> ^~~~
>
> Fixes: 9597624ef606 ('nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path')
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-17 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-17 11:42 [PATCH -next] PCI: remove unused variable rdev Bixuan Cui
2021-04-17 20:36 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).