linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Om Prakash Singh <omp@nvidia.com>
Cc: vidyas@nvidia.com, lorenzo.pieralisi@arm.com,
	bhelgaas@google.com, thierry.reding@gmail.com,
	jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	kthota@nvidia.com, mmaddireddy@nvidia.com
Subject: Re: [RESEND PATCH V1 4/5] PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode
Date: Thu, 27 May 2021 23:00:21 +0200	[thread overview]
Message-ID: <20210527210021.GA32109@rocinante.localdomain> (raw)
In-Reply-To: <20210527120531.GB213718@rocinante.localdomain>

Hi,

> > +	if (pcie->mode == DW_PCIE_EP_TYPE) {
> > +		dev_err(dev, "Tegra PCIe is in EP mode, suspend not allowed");
> > +		return -EPERM;
> > +	}
> 
> Would the -EINVAL be more appropriate here?  It seem more appropriate
> when something is an invalid operation, rather than access to the
> resource being denied (or something along these lines), what do you
> think?

After looking at this again, perhaps -ENOTSUPP would be a better fit,
and then the message could say that the suspend is not supported.

	Krzysztof

  reply	other threads:[~2021-05-27 21:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 11:52 [RESEND PATCH V1 0/5] Update pcie-tegra194 driver Om Prakash Singh
2021-05-27 11:52 ` [RESEND PATCH V1 1/5] PCI: tegra: Fix handling BME_CHGED event Om Prakash Singh
2021-05-27 16:06   ` Bjorn Helgaas
2021-05-27 11:52 ` [RESEND PATCH V1 2/5] PCI: tegra: Fix MSI-X programming Om Prakash Singh
2021-05-27 12:14   ` Krzysztof Wilczyński
2021-05-27 11:52 ` [RESEND PATCH V1 3/5] PCI: tegra: Disable interrupts before entering L2 Om Prakash Singh
2021-05-27 12:13   ` Krzysztof Wilczyński
2021-05-27 11:52 ` [RESEND PATCH V1 4/5] PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode Om Prakash Singh
2021-05-27 12:05   ` Krzysztof Wilczyński
2021-05-27 21:00     ` Krzysztof Wilczyński [this message]
2021-05-27 11:52 ` [RESEND PATCH V1 5/5] PCI: tegra: Cleanup unused code Om Prakash Singh
2021-05-27 12:00 ` [RESEND PATCH V1 0/5] Update pcie-tegra194 driver Krzysztof Wilczyński
2021-05-27 12:49   ` Jon Hunter
2021-05-27 12:52     ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210527210021.GA32109@rocinante.localdomain \
    --to=kw@linux.com \
    --cc=bhelgaas@google.com \
    --cc=jonathanh@nvidia.com \
    --cc=kthota@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mmaddireddy@nvidia.com \
    --cc=omp@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).