From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
kernel@pengutronix.de, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: endpoint: Make struct pci_epf_driver::remove return void
Date: Tue, 13 Jul 2021 08:16:30 +0200 [thread overview]
Message-ID: <20210713061630.e3krhew2wumw4b7r@pengutronix.de> (raw)
In-Reply-To: <20210712205149.GA1675719@bjorn-Precision-5520>
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
Hello Bjorn,
On Mon, Jul 12, 2021 at 03:51:49PM -0500, Bjorn Helgaas wrote:
> On Tue, Feb 23, 2021 at 10:07:57AM +0100, Uwe Kleine-König wrote:
> > The driver core ignores the return value of pci_epf_device_remove()
> > (because there is only little it can do when a device disappears) and
> > there are no pci_epf_drivers with a remove callback.
> >
> > So make it impossible for future drivers to return an unused error code
> > by changing the remove prototype to return void.
> >
> > The real motivation for this change is the quest to make struct
> > bus_type::remove return void, too.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Can you just include this with the rest of your series that depends on
> it, like you did for the s390 patches, so they're all together?
Yeah sure, will resend the complete series later today. I hesitated to
include the pci patch as I didn't know your plans for it and didn't want
to create a mess by interfering with your workflow.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-07-13 6:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 9:07 [PATCH] PCI: endpoint: Make struct pci_epf_driver::remove return void Uwe Kleine-König
2021-05-05 19:53 ` Uwe Kleine-König
2021-05-10 19:26 ` Uwe Kleine-König
2021-06-22 8:02 ` Uwe Kleine-König
2021-06-22 9:59 ` Kishon Vijay Abraham I
2021-06-22 10:10 ` Greg Kroah-Hartman
2021-07-05 15:46 ` Uwe Kleine-König
2021-07-08 9:23 ` Uwe Kleine-König
2021-07-08 10:15 ` Kishon Vijay Abraham I
2021-07-12 20:51 ` Bjorn Helgaas
2021-07-13 6:16 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713061630.e3krhew2wumw4b7r@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).