From: Mikko Perttunen <mperttunen@nvidia.com>
To: rafael@kernel.org, viresh.kumar@linaro.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
krzysztof.kozlowski@canonical.com, lorenzo.pieralisi@arm.com,
robh@kernel.org, kw@linux.com, p.zabel@pengutronix.de,
rui.zhang@intel.com, daniel.lezcano@linaro.org, amitk@kernel.org
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Mikko Perttunen <mperttunen@nvidia.com>
Subject: [PATCH 3/5] memory: tegra186-emc: Handle errors in BPMP response
Date: Wed, 15 Sep 2021 11:55:15 +0300 [thread overview]
Message-ID: <20210915085517.1669675-3-mperttunen@nvidia.com> (raw)
In-Reply-To: <20210915085517.1669675-1-mperttunen@nvidia.com>
The return value from tegra_bpmp_transfer indicates the success or
failure of the IPC transaction with BPMP. If the transaction
succeeded, we also need to check the actual command's result code.
Add code to do this.
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
---
drivers/memory/tegra/tegra186-emc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/tegra186-emc.c
index d65e7c2a580b..abc0c2eeaab7 100644
--- a/drivers/memory/tegra/tegra186-emc.c
+++ b/drivers/memory/tegra/tegra186-emc.c
@@ -197,6 +197,10 @@ static int tegra186_emc_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "failed to EMC DVFS pairs: %d\n", err);
goto put_bpmp;
}
+ if (msg.rx.ret < 0) {
+ dev_err(&pdev->dev, "EMC DVFS MRQ failed: %d (BPMP error code)\n", msg.rx.ret);
+ goto put_bpmp;
+ }
emc->debugfs.min_rate = ULONG_MAX;
emc->debugfs.max_rate = 0;
--
2.32.0
next prev parent reply other threads:[~2021-09-15 8:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 8:55 [PATCH 1/5] thermal: tegra-bpmp: Handle errors in BPMP response Mikko Perttunen
2021-09-15 8:55 ` [PATCH 2/5] reset: " Mikko Perttunen
2021-10-05 9:55 ` Philipp Zabel
2021-10-28 11:54 ` Jon Hunter
2021-11-02 13:10 ` Philipp Zabel
2021-11-12 11:30 ` Jon Hunter
2021-09-15 8:55 ` Mikko Perttunen [this message]
2021-09-20 8:34 ` (subset) [PATCH 3/5] memory: tegra186-emc: " Krzysztof Kozlowski
2021-09-15 8:55 ` [PATCH 4/5] cpufreq: tegra186/tegra194: " Mikko Perttunen
2021-10-04 6:37 ` Viresh Kumar
2021-10-04 6:51 ` Mikko Perttunen
2021-10-04 7:01 ` Viresh Kumar
2021-10-04 7:02 ` Mikko Perttunen
2021-09-15 8:55 ` [PATCH 5/5] PCI: tegra194: " Mikko Perttunen
2021-10-07 18:21 ` Thierry Reding
2021-10-13 12:59 ` Lorenzo Pieralisi
2021-11-29 12:19 ` Lorenzo Pieralisi
2022-02-03 12:22 ` Lorenzo Pieralisi
2021-10-07 18:20 ` [PATCH 1/5] thermal: tegra-bpmp: " Thierry Reding
2022-02-25 12:22 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915085517.1669675-3-mperttunen@nvidia.com \
--to=mperttunen@nvidia.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).