From: Jon Hunter <jonathanh@nvidia.com>
To: Mikko Perttunen <mperttunen@nvidia.com>, <rafael@kernel.org>,
<viresh.kumar@linaro.org>, <thierry.reding@gmail.com>,
<krzysztof.kozlowski@canonical.com>, <lorenzo.pieralisi@arm.com>,
<robh@kernel.org>, <kw@linux.com>, <p.zabel@pengutronix.de>,
<rui.zhang@intel.com>, <daniel.lezcano@linaro.org>,
<amitk@kernel.org>
Cc: <linux-pm@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 2/5] reset: tegra-bpmp: Handle errors in BPMP response
Date: Thu, 28 Oct 2021 12:54:27 +0100 [thread overview]
Message-ID: <397003f8-bf3c-68a4-828c-1254710f714b@nvidia.com> (raw)
In-Reply-To: <20210915085517.1669675-2-mperttunen@nvidia.com>
Hi Philipp,
On 15/09/2021 09:55, Mikko Perttunen wrote:
> The return value from tegra_bpmp_transfer indicates the success or
> failure of the IPC transaction with BPMP. If the transaction
> succeeded, we also need to check the actual command's result code.
> Add code to do this.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> drivers/reset/tegra/reset-bpmp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c
> index 24d3395964cc..4c5bba52b105 100644
> --- a/drivers/reset/tegra/reset-bpmp.c
> +++ b/drivers/reset/tegra/reset-bpmp.c
> @@ -20,6 +20,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
> struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);
> struct mrq_reset_request request;
> struct tegra_bpmp_message msg;
> + int err;
>
> memset(&request, 0, sizeof(request));
> request.cmd = command;
> @@ -30,7 +31,13 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
> msg.tx.data = &request;
> msg.tx.size = sizeof(request);
>
> - return tegra_bpmp_transfer(bpmp, &msg);
> + err = tegra_bpmp_transfer(bpmp, &msg);
> + if (err)
> + return err;
> + if (msg.rx.ret)
> + return -EINVAL;
> +
> + return 0;
> }
>
> static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,
>
I see that you have pulled this into the mainline for v5.15.
Unfortunately, this is causing a regression for the Tegra HDA
controller. We need to fix the Tegra HDA driver but this is too late now
for v5.15 and so we need to revert this change for v5.15. Sorry about
this, but I did not expect this to be pulled in so late.
Jon
--
nvpublic
next prev parent reply other threads:[~2021-10-28 11:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 8:55 [PATCH 1/5] thermal: tegra-bpmp: Handle errors in BPMP response Mikko Perttunen
2021-09-15 8:55 ` [PATCH 2/5] reset: " Mikko Perttunen
2021-10-05 9:55 ` Philipp Zabel
2021-10-28 11:54 ` Jon Hunter [this message]
2021-11-02 13:10 ` Philipp Zabel
2021-11-12 11:30 ` Jon Hunter
2021-09-15 8:55 ` [PATCH 3/5] memory: tegra186-emc: " Mikko Perttunen
2021-09-20 8:34 ` (subset) " Krzysztof Kozlowski
2021-09-15 8:55 ` [PATCH 4/5] cpufreq: tegra186/tegra194: " Mikko Perttunen
2021-10-04 6:37 ` Viresh Kumar
2021-10-04 6:51 ` Mikko Perttunen
2021-10-04 7:01 ` Viresh Kumar
2021-10-04 7:02 ` Mikko Perttunen
2021-09-15 8:55 ` [PATCH 5/5] PCI: tegra194: " Mikko Perttunen
2021-10-07 18:21 ` Thierry Reding
2021-10-13 12:59 ` Lorenzo Pieralisi
2021-11-29 12:19 ` Lorenzo Pieralisi
2022-02-03 12:22 ` Lorenzo Pieralisi
2021-10-07 18:20 ` [PATCH 1/5] thermal: tegra-bpmp: " Thierry Reding
2022-02-25 12:22 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=397003f8-bf3c-68a4-828c-1254710f714b@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mperttunen@nvidia.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).