From: Bjorn Helgaas <helgaas@kernel.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: tsbogend@alpha.franken.de, robh@kernel.org, arnd@arndb.de,
catalin.marinas@arm.com, Liviu.Dudau@arm.com,
bhelgaas@google.com, matthias.bgg@gmail.com,
gregkh@linuxfoundation.org, linux-mips@vger.kernel.org,
linux-pci@vger.kernel.org, linux-staging@lists.linux.dev,
neil@brown.name, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] PCI: allow architecture specific implementation of pci_remap_iospace()
Date: Fri, 24 Sep 2021 21:42:04 -0500 [thread overview]
Message-ID: <20210925024204.GA459123@bhelgaas> (raw)
In-Reply-To: <20210924211139.3477-5-sergio.paracuellos@gmail.com>
s/PCI: allow architecture specific implementation of/
PCI: Allow architecture-specific pci_remap_iospace()/
(in subject)
On Fri, Sep 24, 2021 at 11:11:37PM +0200, Sergio Paracuellos wrote:
> pci_remap_iospace() was originally meant as an architecture specific helper,
> but it moved into generic code after all architectures had the same requirements.
> MIPS has different requirements so it should not be shared. The way for doing
> this will be using a macro 'pci_remap_iospace' defined for those architectures
> that need a special treatement. Hence, put core api function inside preprocesor
> conditional code for 'pci_remap_iospace' definition.
Rewrap above to fit in 75 columns so "git log" output doesn't wrap.
Add blank line between paragraphs.
s/treatement/treatment/
s/api/API/
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
With above fixed,
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pci/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index ce2ab62b64cf..0ec57bb01a88 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4123,6 +4123,7 @@ unsigned long __weak pci_address_to_pio(phys_addr_t address)
> * architectures that have memory mapped IO functions defined (and the
> * PCI_IOBASE value defined) should call this function.
> */
> +#ifndef pci_remap_iospace
> int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr)
> {
> #if defined(PCI_IOBASE) && defined(CONFIG_MMU)
> @@ -4146,6 +4147,7 @@ int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr)
> #endif
> }
> EXPORT_SYMBOL(pci_remap_iospace);
> +#endif
>
> /**
> * pci_unmap_iospace - Unmap the memory mapped I/O space
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-09-25 2:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 21:11 [PATCH 0/6] MIPS: ralink: fix PCI IO resources Sergio Paracuellos
2021-09-24 21:11 ` [PATCH 1/6] Revert "MIPS: ralink: don't define PC_IOBASE but increase IO_SPACE_LIMIT" Sergio Paracuellos
2021-09-24 21:11 ` [PATCH 2/6] Revert "staging: mt7621-pci: set end limit for 'ioport_resource'" Sergio Paracuellos
2021-09-25 17:33 ` Arnd Bergmann
2021-09-24 21:11 ` [PATCH 3/6] MIPS: ralink: set PCI_IOBASE to 'mips_io_port_base' Sergio Paracuellos
2021-09-25 17:32 ` Arnd Bergmann
2021-09-24 21:11 ` [PATCH 4/6] PCI: allow architecture specific implementation of pci_remap_iospace() Sergio Paracuellos
2021-09-25 2:42 ` Bjorn Helgaas [this message]
2021-09-25 17:38 ` Arnd Bergmann
2021-09-24 21:11 ` [PATCH 5/6] MIPS: implement architecture dependent 'pci_remap_iospace()' Sergio Paracuellos
2021-09-25 17:32 ` Arnd Bergmann
2021-09-25 18:08 ` Sergio Paracuellos
2021-09-25 19:34 ` Arnd Bergmann
2021-09-25 20:16 ` Sergio Paracuellos
2021-09-24 21:11 ` [PATCH 6/6] staging: mt7621-pci: properly adjust base address for the IO window Sergio Paracuellos
2021-09-25 17:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210925024204.GA459123@bhelgaas \
--to=helgaas@kernel.org \
--cc=Liviu.Dudau@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
--cc=robh@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).