* [PATCH] PCI: vmd: Remove duplicated include in vmd.c
@ 2021-11-04 6:37 Wan Jiabing
2021-11-04 11:15 ` Krzysztof Wilczyński
2021-11-04 14:40 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2021-11-04 6:37 UTC (permalink / raw)
To: Nirmal Patel, Jonathan Derrick, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, linux-pci,
linux-kernel
Cc: jiabing.wan, Wan Jiabing
Fix following checkincludes.pl warning:
./drivers/pci/controller/vmd.c: linux/device.h is included more than once.
The include is in line 7. Remove the duplicated here.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/pci/controller/vmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index b48d9998e324..a45e8e59d3d4 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -10,7 +10,6 @@
#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/device.h>
#include <linux/msi.h>
#include <linux/pci.h>
#include <linux/pci-acpi.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: vmd: Remove duplicated include in vmd.c
2021-11-04 6:37 [PATCH] PCI: vmd: Remove duplicated include in vmd.c Wan Jiabing
@ 2021-11-04 11:15 ` Krzysztof Wilczyński
2021-11-04 14:40 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Wilczyński @ 2021-11-04 11:15 UTC (permalink / raw)
To: Wan Jiabing
Cc: Nirmal Patel, Jonathan Derrick, Lorenzo Pieralisi, Rob Herring,
Bjorn Helgaas, linux-pci, linux-kernel, jiabing.wan
Hi,
[...]
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -10,7 +10,6 @@
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/device.h>
> #include <linux/msi.h>
> #include <linux/pci.h>
> #include <linux/pci-acpi.h>
Wan, thank you for reporting this!
Bjorn, the patch I sent earlier:
https://lore.kernel.org/all/20211013003145.1107148-1-kw@linux.com/
Accidentally left the include at the top that was intended to me moved to
be before the linux/msi.h to reflect previous order of the asm/device.h and
asm/msi.h had.
I must have forgotten to remove the one from the top later. Sincere
apologies!
I can send an update, or we can squeeze these two patches together. Sorry for
adding you more work to do.
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: vmd: Remove duplicated include in vmd.c
2021-11-04 6:37 [PATCH] PCI: vmd: Remove duplicated include in vmd.c Wan Jiabing
2021-11-04 11:15 ` Krzysztof Wilczyński
@ 2021-11-04 14:40 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2021-11-04 14:40 UTC (permalink / raw)
To: Wan Jiabing
Cc: Nirmal Patel, Jonathan Derrick, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, linux-pci,
linux-kernel, jiabing.wan
On Thu, Nov 04, 2021 at 02:37:19AM -0400, Wan Jiabing wrote:
> Fix following checkincludes.pl warning:
> ./drivers/pci/controller/vmd.c: linux/device.h is included more than once.
>
> The include is in line 7. Remove the duplicated here.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Squashed in, thanks!
> ---
> drivers/pci/controller/vmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index b48d9998e324..a45e8e59d3d4 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -10,7 +10,6 @@
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/device.h>
> #include <linux/msi.h>
> #include <linux/pci.h>
> #include <linux/pci-acpi.h>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-04 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 6:37 [PATCH] PCI: vmd: Remove duplicated include in vmd.c Wan Jiabing
2021-11-04 11:15 ` Krzysztof Wilczyński
2021-11-04 14:40 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).