From: Jim Quinlan <jim2101024@gmail.com>
To: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Rob Herring <robh@kernel.org>, Mark Brown <broonie@kernel.org>,
bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com,
james.quinlan@broadcom.com
Cc: Sean V Kelley <sean.v.kelley@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Keith Busch <kbusch@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v8 6/8] PCI/portdrv: Do not turn off subdev regulators if EP can wake up
Date: Wed, 10 Nov 2021 17:14:46 -0500 [thread overview]
Message-ID: <20211110221456.11977-7-jim2101024@gmail.com> (raw)
In-Reply-To: <20211110221456.11977-1-jim2101024@gmail.com>
If any downstream device may wake up during S2/S3 suspend, we do not want
to turn off its power when suspending.
Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
---
drivers/pci/pci.h | 1 +
drivers/pci/pcie/portdrv_pci.c | 43 +++++++++++++++++++++++++++++-----
2 files changed, 38 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index 3f6cf75b91cc..27abb977d0ec 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -746,6 +746,7 @@ extern const struct attribute_group aspm_ctrl_attr_group;
extern const struct attribute_group pci_dev_reset_method_attr_group;
struct subdev_regulators {
+ bool ep_wakeup_capable;
unsigned int num_supplies;
struct regulator_bulk_data supplies[];
};
diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
index 9330cfbebdc1..717e816d0fc8 100644
--- a/drivers/pci/pcie/portdrv_pci.c
+++ b/drivers/pci/pcie/portdrv_pci.c
@@ -111,24 +111,55 @@ bool pcie_is_port_dev(struct pci_dev *dev)
}
EXPORT_SYMBOL_GPL(pcie_is_port_dev);
+static int pci_dev_may_wakeup(struct pci_dev *dev, void *data)
+{
+ bool *ret = data;
+
+ if (device_may_wakeup(&dev->dev)) {
+ *ret = true;
+ dev_dbg(&dev->dev, "disable cancelled for wake-up device\n");
+ }
+ return (int) *ret;
+}
+
static int subdev_regulator_resume(struct pci_dev *dev)
{
struct subdev_regulators *sr = dev->dev.driver_data;
- if (sr)
- return regulator_bulk_enable(sr->num_supplies, sr->supplies);
+ if (!sr)
+ return 0;
- return 0;
+ if (sr->ep_wakeup_capable) {
+ /*
+ * We are resuming from a suspend. In the previous suspend
+ * we did not disable the power supplies, so there is no
+ * need to enable them (and falsely increase their usage
+ * count).
+ */
+ sr->ep_wakeup_capable = false;
+ return 0;
+ }
+
+ return regulator_bulk_enable(sr->num_supplies, sr->supplies);
}
static int subdev_regulator_suspend(struct pci_dev *dev, pm_message_t state)
{
struct subdev_regulators *sr = dev->dev.driver_data;
- if (sr)
- return regulator_bulk_disable(sr->num_supplies, sr->supplies);
+ if (!sr)
+ return 0;
+ /*
+ * If at least one device on this bus is enabled as a
+ * wake-up source, do not turn off regulators.
+ */
+ sr->ep_wakeup_capable = false;
+ pci_walk_bus(dev->bus, pci_dev_may_wakeup,
+ &sr->ep_wakeup_capable);
+ if (sr->ep_wakeup_capable)
+ return 0;
- return 0;
+ return regulator_bulk_disable(sr->num_supplies, sr->supplies);
}
/*
--
2.17.1
next prev parent reply other threads:[~2021-11-10 22:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 22:14 [PATCH v8 0/8] PCI: brcmstb: have portdrv turn on sub-device power Jim Quinlan
2021-11-10 22:14 ` [PATCH v8 1/8] PCI: brcmstb: Change brcm_phy_stop() to return void Jim Quinlan
2021-11-11 21:57 ` Bjorn Helgaas
2021-11-15 20:56 ` Jim Quinlan
2021-11-16 20:40 ` Bjorn Helgaas
2021-11-10 22:14 ` [PATCH v8 2/8] dt-bindings: PCI: Correct brcmstb interrupts, interrupt-map Jim Quinlan
2021-11-10 22:14 ` [PATCH v8 3/8] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators Jim Quinlan
2021-11-11 22:17 ` Bjorn Helgaas
2021-11-12 18:25 ` Jim Quinlan
2021-11-12 20:20 ` Bjorn Helgaas
2021-11-12 21:46 ` Rob Herring
2021-11-13 11:38 ` Pali Rohár
2021-11-10 22:14 ` [PATCH v8 4/8] PCI/portdrv: Create pcie_is_port_dev() func from existing code Jim Quinlan
2021-11-11 21:51 ` Florian Fainelli
2021-11-11 22:53 ` Rob Herring
2021-11-11 23:50 ` Krzysztof Wilczyński
2021-11-12 18:14 ` Jim Quinlan
2021-11-10 22:14 ` [PATCH v8 5/8] PCI/portdrv: add mechanism to turn on subdev regulators Jim Quinlan
2021-11-11 9:44 ` kernel test robot
2021-11-11 22:12 ` Bjorn Helgaas
2021-11-11 22:50 ` Rob Herring
2021-11-11 22:56 ` Rob Herring
2021-11-15 20:44 ` Jim Quinlan
2021-11-16 17:41 ` Rob Herring
2021-11-16 20:53 ` Pali Rohár
2021-11-17 15:14 ` Jim Quinlan
2021-11-17 15:45 ` Pali Rohár
2021-11-18 15:36 ` Jim Quinlan
2021-11-18 15:50 ` Pali Rohár
2021-11-17 14:46 ` Jim Quinlan
2021-11-11 23:38 ` Krzysztof Wilczyński
2021-11-15 20:26 ` Jim Quinlan
2021-11-10 22:14 ` Jim Quinlan [this message]
2021-11-10 22:14 ` [PATCH v8 7/8] PCI: brcmstb: Split brcm_pcie_setup() into two funcs Jim Quinlan
2021-11-10 22:14 ` [PATCH v8 8/8] PCI: brcmstb: Add control of subdevice voltage regulators Jim Quinlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110221456.11977-7-jim2101024@gmail.com \
--to=jim2101024@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=james.quinlan@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nsaenz@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=robh@kernel.org \
--cc=sean.v.kelley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).