From: Gerd Hoffmann <kraxel@redhat.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, mst@redhat.com,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] pciehp: fast unplug for virtual machines
Date: Fri, 12 Nov 2021 12:28:58 +0100 [thread overview]
Message-ID: <20211112112858.33bcm6jrvqb7z7uo@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211111215019.GA1332430@bhelgaas>
Hi,
> "Virtual" doesn't seem like quite the right descriptor here. That's
> one use case, but I think the parameter should describe the actual
> *effect*, not the use case, e.g., something related to the delay after
> the attention button.
Well, it's enabled only for virtual pcie ports because I could hardly
enable it by default otherwise.
There is another delay in remove_board(), mst suggests removing that
too, and that surely would be something we can't do on physical
hardware ...
So I'd prefer to keep the name.
> If it's practical, I think it would be nicer to have a sysfs attribute
> instead of a kernel boot parameter. Then we wouldn't have to reboot
> to change this, and it could be generalized to allow arbitrary delays,
> i.e., no delay, 5 seconds, or whatever the admin decides.
It's a module parameter so will show up in
/sys/module/pciehp/parameters/ and it is writable by root.
[ will address the other things mentioned in v2 ].
take care,
Gerd
next prev parent reply other threads:[~2021-11-12 11:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 9:02 [PATCH] pciehp: fast unplug for virtual machines Gerd Hoffmann
2021-11-11 17:00 ` Michael S. Tsirkin
2021-11-12 9:56 ` Gerd Hoffmann
2021-11-12 10:09 ` Michael S. Tsirkin
2021-11-11 21:50 ` Bjorn Helgaas
2021-11-12 11:28 ` Gerd Hoffmann [this message]
2021-11-12 0:00 ` Krzysztof Wilczyński
2021-11-14 16:39 ` Lukas Wunner
2021-11-14 17:24 ` Michael S. Tsirkin
2021-11-14 18:06 ` Lukas Wunner
2021-11-14 22:37 ` Michael S. Tsirkin
2021-11-15 9:59 ` Gerd Hoffmann
2021-11-15 7:45 ` Lukas Wunner
2021-11-15 10:09 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112112858.33bcm6jrvqb7z7uo@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).