From: Gerd Hoffmann <kraxel@redhat.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-pci@vger.kernel.org, mst@redhat.com,
Bjorn Helgaas <bhelgaas@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pciehp: fast unplug for virtual machines
Date: Mon, 15 Nov 2021 11:09:43 +0100 [thread overview]
Message-ID: <20211115100943.ezvirlrxc2qzms3i@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211114163958.GA7211@wunner.de>
Hi,
> Same for the 1 second delay in remove_board(). That's mandated by
> PCIe r5.0, sec. 6.7.1.8, but it's only observed if a Power Controller
> is present. So just clear the Power Controller Present bit in the
> Slot Capabilities register and the delay is gone.
Well, the power control bit is a useful data channel. qemu can use that
to figure whenever the guest uses the device (power is on) or not (power
is off). And in case power is off anyway we can simply remove the
device without the attention button dance.
take care,
Gerd
prev parent reply other threads:[~2021-11-15 10:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 9:02 [PATCH] pciehp: fast unplug for virtual machines Gerd Hoffmann
2021-11-11 17:00 ` Michael S. Tsirkin
2021-11-12 9:56 ` Gerd Hoffmann
2021-11-12 10:09 ` Michael S. Tsirkin
2021-11-11 21:50 ` Bjorn Helgaas
2021-11-12 11:28 ` Gerd Hoffmann
2021-11-12 0:00 ` Krzysztof Wilczyński
2021-11-14 16:39 ` Lukas Wunner
2021-11-14 17:24 ` Michael S. Tsirkin
2021-11-14 18:06 ` Lukas Wunner
2021-11-14 22:37 ` Michael S. Tsirkin
2021-11-15 9:59 ` Gerd Hoffmann
2021-11-15 7:45 ` Lukas Wunner
2021-11-15 10:09 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115100943.ezvirlrxc2qzms3i@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).