From: "Pali Rohár" <pali@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "Marek Behún" <kabel@kernel.org>,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
"Bjorn Helgaas" <helgaas@kernel.org>
Subject: Re: [PATCH dt + pci 1/2] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property
Date: Fri, 12 Nov 2021 16:32:08 +0100 [thread overview]
Message-ID: <20211112153208.s4nuckz7js4fipce@pali> (raw)
In-Reply-To: <YY6HYM4T+A+tm85P@robh.at.kernel.org>
On Friday 12 November 2021 09:25:20 Rob Herring wrote:
> On Sun, Oct 31, 2021 at 04:07:05PM +0100, Marek Behún wrote:
> > + If present, this property specifies slot power limit in milliwatts. Host
> > + drivers can parse this property and use it for programming Root Port or host
> > + bridge, or for composing and sending PCIe Set_Slot_Power_Limit messages
> > + through the Root Port or host bridge when transitioning PCIe link from a
> > + non-DL_Up Status to a DL_Up Status.
>
> If your slots are behind a switch, then doesn't this apply to any bridge
> port?
The main issue here is that pci.txt (and also scheme on github) is
mixing host bridge and root ports into one node. This new property
should be defined at the same place where is supports-clkreq or
reset-gpios, as it belongs to them.
And you are right, that this new property should be defined only for
root ports and downstream ports of switch.
next prev parent reply other threads:[~2021-11-12 15:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 15:07 [PATCH dt + pci 1/2] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property Marek Behún
2021-10-31 15:07 ` [PATCH dt + pci 2/2] PCI: Add function for parsing `slot-power-limit-milliwatt` DT property Marek Behún
2022-01-07 18:04 ` Marek Behún
2022-01-07 21:17 ` Rob Herring
2022-01-12 22:08 ` Bjorn Helgaas
2022-01-12 22:28 ` Pali Rohár
2022-01-13 0:00 ` Bjorn Helgaas
2021-11-12 15:25 ` [PATCH dt + pci 1/2] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property Rob Herring
2021-11-12 15:32 ` Pali Rohár [this message]
2021-11-12 16:30 ` Rob Herring
2021-11-12 17:12 ` Pali Rohár
2021-11-12 17:24 ` Marek Behún
2021-11-12 20:56 ` Rob Herring
2021-11-13 11:31 ` Pali Rohár
2021-11-16 21:31 ` Pali Rohár
2022-01-05 14:14 ` Marek Behún
2022-01-05 14:27 ` Rob Herring
2022-01-05 15:14 ` Pali Rohár
2022-01-05 15:26 ` Rob Herring
2022-01-05 15:36 ` Pali Rohár
2022-01-05 17:11 ` Marek Behún
2022-02-18 11:31 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112153208.s4nuckz7js4fipce@pali \
--to=pali@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=kabel@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).