From: "Pali Rohár" <pali@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "Marek Behún" <kabel@kernel.org>,
devicetree@vger.kernel.org, PCI <linux-pci@vger.kernel.org>,
"Bjorn Helgaas" <helgaas@kernel.org>
Subject: Re: [PATCH dt + pci 1/2] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property
Date: Tue, 16 Nov 2021 22:31:01 +0100 [thread overview]
Message-ID: <20211116213101.enedflqtezel5rmq@pali> (raw)
In-Reply-To: <20211113113106.a3ludtlycnrmbvnh@pali>
On Saturday 13 November 2021 12:31:06 Pali Rohár wrote:
> On Friday 12 November 2021 14:56:26 Rob Herring wrote:
> > The only
> > versioning we have ATM is the kernel requires a minimum version of
> > dtschema (which we'll have to bump for all this).
> >
> > We could have something like:
> >
> > old-pci-bridge.yaml:
> > allOf:
> > - $ref: pci-host-bridge.yaml#
> > - $ref: pcie-port.yaml#
> >
> > new-pci-bridge.yaml:
> > allOf:
> > - $ref: pci-host-bridge.yaml#
> > properties:
> > pci@0:
> > $ref: pcie-port.yaml#
> >
> > And then both of the above schemas will have $ref to a pci-bridge.yaml
> > schema which should be most of pci-bus.yaml. linux,pci-domain and
> > dma-ranges? go to pci-host-bridge.yaml. max-link-speed, num-lanes,
> > reset-gpios, slot-power-limit-milliwatt, and the pending supply
> > additions (Broadcom) go to pcie-port.yaml.
>
> This looks like a nice solution.
>
> I would propose just one other thing: Do not allow new kernel drivers
> to use old-pci-bridge.yaml schema, so new drivers would not use old
> "deprecated" APIs...
>
> So should I prepare some schemas and send it for review via github pull
> request mechanism? (I'm not sure how is that github project related to
> kernel DTS bindings and how is reviewing on it going...)
I prepared something for discussion:
https://github.com/devicetree-org/dt-schema/pull/64
next prev parent reply other threads:[~2021-11-16 21:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 15:07 [PATCH dt + pci 1/2] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property Marek Behún
2021-10-31 15:07 ` [PATCH dt + pci 2/2] PCI: Add function for parsing `slot-power-limit-milliwatt` DT property Marek Behún
2022-01-07 18:04 ` Marek Behún
2022-01-07 21:17 ` Rob Herring
2022-01-12 22:08 ` Bjorn Helgaas
2022-01-12 22:28 ` Pali Rohár
2022-01-13 0:00 ` Bjorn Helgaas
2021-11-12 15:25 ` [PATCH dt + pci 1/2] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property Rob Herring
2021-11-12 15:32 ` Pali Rohár
2021-11-12 16:30 ` Rob Herring
2021-11-12 17:12 ` Pali Rohár
2021-11-12 17:24 ` Marek Behún
2021-11-12 20:56 ` Rob Herring
2021-11-13 11:31 ` Pali Rohár
2021-11-16 21:31 ` Pali Rohár [this message]
2022-01-05 14:14 ` Marek Behún
2022-01-05 14:27 ` Rob Herring
2022-01-05 15:14 ` Pali Rohár
2022-01-05 15:26 ` Rob Herring
2022-01-05 15:36 ` Pali Rohár
2022-01-05 17:11 ` Marek Behún
2022-02-18 11:31 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116213101.enedflqtezel5rmq@pali \
--to=pali@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=kabel@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).