From: Bjorn Helgaas <firstname.lastname@example.org> To: Thorsten Leemhuis <email@example.com> Cc: "Krzysztof Wilczyński" <firstname.lastname@example.org>, "Ville Syrjälä" <email@example.com>, "Bjorn Helgaas" <firstname.lastname@example.org>, "Oliver O'Halloran" <email@example.com>, firstname.lastname@example.org Subject: Re: [REGRESSION] 527139d738d7 ("PCI/sysfs: Convert "rom" to static attribute") Date: Thu, 20 Jan 2022 09:00:51 -0600 [thread overview] Message-ID: <20220120150051.GA1015185@bhelgaas> (raw) In-Reply-To: <email@example.com> On Thu, Jan 20, 2022 at 02:19:05PM +0100, Thorsten Leemhuis wrote: > On 17.12.21 23:49, Krzysztof Wilczyński wrote: > > Hi Ville, > > > > Thank you for letting us know, and sincere apologies for troubles! > > > > [...] > >>>> The pci sysfs "rom" file has disappeared for VGA devices. > >>>> Looks to be a regression from commit 527139d738d7 ("PCI/sysfs: > >>>> Convert "rom" to static attribute"). > >>>> > >>>> Some kind of ordering issue between the sysfs file creation > >>>> vs. pci_fixup_video() perhaps? > >>> > >>> Can you attach your complete "lspci -vv" output? Also, which is the > >>> default device? I think there's a "boot_vga" sysfs file that shows > >>> this. "find /sys -name boot_vga | xargs grep ." > >> > >> All I have is Intel iGPUs so it's always 00:02.0. > >> > >> $ cat /sys/bus/pci/devices/0000\:00\:02.0/boot_vga > >> 1 > >> $ cat /sys/bus/pci/devices/0000\:00\:02.0/rom > >> cat: '/sys/bus/pci/devices/0000:00:02.0/rom': No such file or directory > >> > >> I've attached the full lspci from my IVB laptop, but the problem > >> happens on every machine (with an iGPU at least). > >> > >> I presume with a discrete GPU it might not happen since they > >> actually have a real ROM. > > > > Admittedly, the automated testing I was running before the patch was released > > didn't catch this. I primarily focused on trying to catch the race condition > > related to the ROM attribute creation. > > > > I need to look into how to properly address this problem as if we were to > > revert the ROM attribute changes, then we would introduce the race condition > > we've had back. > > > > Again, apologies for troubles this caused! > > What's the status of this regression and getting it fixed? It looks like > there was no progress for quite a while. Could anyone please provide a > status update? What a coincidence. Krzysztof and I chatted about this yesterday. No progress to report yet, but we are working on it. Bjorn
next prev parent reply other threads:[~2022-01-20 15:01 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-17 10:44 Ville Syrjälä 2021-12-17 17:29 ` Bjorn Helgaas 2021-12-17 17:45 ` Ville Syrjälä 2021-12-17 22:49 ` Krzysztof Wilczyński 2022-01-20 13:19 ` Thorsten Leemhuis 2022-01-20 15:00 ` Bjorn Helgaas [this message] 2022-01-20 15:05 ` Thorsten Leemhuis 2022-01-22 0:24 ` Bjorn Helgaas 2022-01-25 18:56 ` Ville Syrjälä 2021-12-18 6:10 ` Thorsten Leemhuis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220120150051.GA1015185@bhelgaas \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [REGRESSION] 527139d738d7 ("PCI/sysfs: Convert "rom" to static attribute")' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).