From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: pali@kernel.org, linux-pci@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH phy v4 5/5] Revert "PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware"
Date: Thu, 24 Feb 2022 15:37:21 +0000 [thread overview]
Message-ID: <20220224153720.GA5579@lpieralisi> (raw)
In-Reply-To: <20220224151718.7679-1-kabel@kernel.org>
On Thu, Feb 24, 2022 at 04:17:18PM +0100, Marek Behún wrote:
> From: Pali Rohár <pali@kernel.org>
>
> This reverts commit b0c6ae0f8948a2be6bf4e8b4bbab9ca1343289b6.
>
> Armada 3720 phy driver (phy-mvebu-a3700-comphy.c) does not return
> -EOPNOTSUPP from phy_power_on() callback anymore.
>
> So remove dead code which handles -EOPNOTSUPP return value.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> Dear Lorenzo,
>
> could you please give your Ack for this, so that Vinod can apply it
> with the rest of the comphy series?
> The series can be found at
> https://lore.kernel.org/linux-phy/20220203214444.1508-1-kabel@kernel.org/
>
> Marek
> ---
> drivers/pci/controller/pci-aardvark.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
> index 4f5b44827d21..6bae688852a5 100644
> --- a/drivers/pci/controller/pci-aardvark.c
> +++ b/drivers/pci/controller/pci-aardvark.c
> @@ -1482,9 +1482,7 @@ static int advk_pcie_enable_phy(struct advk_pcie *pcie)
> }
>
> ret = phy_power_on(pcie->phy);
> - if (ret == -EOPNOTSUPP) {
> - dev_warn(&pcie->pdev->dev, "PHY unsupported by firmware\n");
> - } else if (ret) {
> + if (ret) {
> phy_exit(pcie->phy);
> return ret;
> }
> --
> 2.34.1
>
prev parent reply other threads:[~2022-02-24 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 15:17 [PATCH phy v4 5/5] Revert "PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware" Marek Behún
2022-02-24 15:37 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224153720.GA5579@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=kabel@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=pali@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).