* [PATCH phy v4 5/5] Revert "PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware"
@ 2022-02-24 15:17 Marek Behún
2022-02-24 15:37 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Marek Behún @ 2022-02-24 15:17 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: pali, linux-pci, Vinod Koul, Marek Behún, Miquel Raynal
From: Pali Rohár <pali@kernel.org>
This reverts commit b0c6ae0f8948a2be6bf4e8b4bbab9ca1343289b6.
Armada 3720 phy driver (phy-mvebu-a3700-comphy.c) does not return
-EOPNOTSUPP from phy_power_on() callback anymore.
So remove dead code which handles -EOPNOTSUPP return value.
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
Dear Lorenzo,
could you please give your Ack for this, so that Vinod can apply it
with the rest of the comphy series?
The series can be found at
https://lore.kernel.org/linux-phy/20220203214444.1508-1-kabel@kernel.org/
Marek
---
drivers/pci/controller/pci-aardvark.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
index 4f5b44827d21..6bae688852a5 100644
--- a/drivers/pci/controller/pci-aardvark.c
+++ b/drivers/pci/controller/pci-aardvark.c
@@ -1482,9 +1482,7 @@ static int advk_pcie_enable_phy(struct advk_pcie *pcie)
}
ret = phy_power_on(pcie->phy);
- if (ret == -EOPNOTSUPP) {
- dev_warn(&pcie->pdev->dev, "PHY unsupported by firmware\n");
- } else if (ret) {
+ if (ret) {
phy_exit(pcie->phy);
return ret;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH phy v4 5/5] Revert "PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware"
2022-02-24 15:17 [PATCH phy v4 5/5] Revert "PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware" Marek Behún
@ 2022-02-24 15:37 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2022-02-24 15:37 UTC (permalink / raw)
To: Marek Behún; +Cc: pali, linux-pci, Vinod Koul, Miquel Raynal
On Thu, Feb 24, 2022 at 04:17:18PM +0100, Marek Behún wrote:
> From: Pali Rohár <pali@kernel.org>
>
> This reverts commit b0c6ae0f8948a2be6bf4e8b4bbab9ca1343289b6.
>
> Armada 3720 phy driver (phy-mvebu-a3700-comphy.c) does not return
> -EOPNOTSUPP from phy_power_on() callback anymore.
>
> So remove dead code which handles -EOPNOTSUPP return value.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> Dear Lorenzo,
>
> could you please give your Ack for this, so that Vinod can apply it
> with the rest of the comphy series?
> The series can be found at
> https://lore.kernel.org/linux-phy/20220203214444.1508-1-kabel@kernel.org/
>
> Marek
> ---
> drivers/pci/controller/pci-aardvark.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
> index 4f5b44827d21..6bae688852a5 100644
> --- a/drivers/pci/controller/pci-aardvark.c
> +++ b/drivers/pci/controller/pci-aardvark.c
> @@ -1482,9 +1482,7 @@ static int advk_pcie_enable_phy(struct advk_pcie *pcie)
> }
>
> ret = phy_power_on(pcie->phy);
> - if (ret == -EOPNOTSUPP) {
> - dev_warn(&pcie->pdev->dev, "PHY unsupported by firmware\n");
> - } else if (ret) {
> + if (ret) {
> phy_exit(pcie->phy);
> return ret;
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-24 15:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 15:17 [PATCH phy v4 5/5] Revert "PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware" Marek Behún
2022-02-24 15:37 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).