From: Bjorn Helgaas <helgaas@kernel.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Bjorn Helgaas <bhelgaas@google.com>,
Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH v9 00/11] vgaarb: Rework default VGA device selection
Date: Fri, 25 Feb 2022 16:15:23 -0600 [thread overview]
Message-ID: <20220225221523.GA385757@bhelgaas> (raw)
In-Reply-To: <20220224224753.297579-1-helgaas@kernel.org>
On Thu, Feb 24, 2022 at 04:47:42PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Current default VGA device selection fails in some cases because part of it
> is done in the vga_arb_device_init() subsys_initcall, and some arches
> enumerate PCI devices in pcibios_init(), which runs *after* that.
>
> The big change from the v8 posting is that this moves vgaarb.c from
> drivers/gpu/vga to drivers/pci because it really has nothing to do with
> GPUs or DRM.
I provisionally applied this to pci/vga and put it into -next just
to get a little runtime on it.
But I'd prefer not to unilaterally yank this out of drivers/gpu
without a consensus from the GPU folks that this is the right thing to
do.
Any thoughts? If it seems OK to you, I think patch 1/11 (the move
itself) is all you would need to look at, although of course I would
still be grateful for any review and feedback on the rest.
After it's in drivers/pci, all the blame for any issues would come my
way.
Bjorn
next prev parent reply other threads:[~2022-02-25 22:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 22:47 [PATCH v9 00/11] vgaarb: Rework default VGA device selection Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 01/11] PCI/VGA: Move vgaarb to drivers/pci Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 02/11] PCI/VGA: Move vga_arb_integrated_gpu() earlier in file Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 03/11] PCI/VGA: Factor out vga_select_framebuffer_device() Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 04/11] PCI/VGA: Factor out default VGA device selection Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 05/11] PCI/VGA: Move firmware default device detection to ADD_DEVICE path Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 06/11] PCI/VGA: Move non-legacy VGA " Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 07/11] PCI/VGA: Move disabled VGA device " Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 08/11] PCI/VGA: Remove empty vga_arb_device_card_gone() Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 09/11] PCI/VGA: Log bridge control messages when adding devices Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 10/11] PCI/VGA: Use unsigned format string to print lock counts Bjorn Helgaas
2022-02-24 22:47 ` [PATCH v9 11/11] PCI/VGA: Replace full MIT license text with SPDX identifier Bjorn Helgaas
2022-02-25 22:15 ` Bjorn Helgaas [this message]
2022-03-09 16:29 ` [PATCH v9 00/11] vgaarb: Rework default VGA device selection Bjorn Helgaas
2022-03-10 3:56 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225221523.GA385757@bhelgaas \
--to=helgaas@kernel.org \
--cc=airlied@linux.ie \
--cc=bhelgaas@google.com \
--cc=chenhuacai@loongson.cn \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).