* [PATCH -next?] x86: PCI: asm/pci_x86.h needs more #includes
@ 2022-02-26 21:37 Randy Dunlap
2022-03-14 19:54 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-02-26 21:37 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Mark Brown, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, x86, linux-pci
<asm/pci_x86.h> uses EINVAL, __init, and raw_spinlock_t, so it
should #include the appropriate files to prevent build errors.
../arch/x86/include/asm/pci_x86.h:150:10: error: ‘EINVAL’ undeclared (first use in this function)
return -EINVAL;
../arch/x86/include/asm/pci_x86.h:105:8: error: unknown type name ‘raw_spinlock_t’
extern raw_spinlock_t pci_config_lock;
../arch/x86/include/asm/pci_x86.h:141:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘dmi_check_pciprobe’
extern void __init dmi_check_pciprobe(void);
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: linux-pci@vger.kernel.org
---
Without this patch, I am seeing *many* build errors in
linux-next-20220225.
I don't know why this showed up in linux-next-20220225 all of a
sudden.
arch/x86/include/asm/pci_x86.h | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20220225.orig/arch/x86/include/asm/pci_x86.h
+++ linux-next-20220225/arch/x86/include/asm/pci_x86.h
@@ -5,7 +5,10 @@
* (c) 1999 Martin Mares <mj@ucw.cz>
*/
+#include <linux/errno.h>
+#include <linux/init.h>
#include <linux/ioport.h>
+#include <linux/spinlock.h>
#undef DEBUG
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next?] x86: PCI: asm/pci_x86.h needs more #includes
2022-02-26 21:37 [PATCH -next?] x86: PCI: asm/pci_x86.h needs more #includes Randy Dunlap
@ 2022-03-14 19:54 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2022-03-14 19:54 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Mark Brown, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, x86, linux-pci
On Sat, Feb 26, 2022 at 01:37:03PM -0800, Randy Dunlap wrote:
> <asm/pci_x86.h> uses EINVAL, __init, and raw_spinlock_t, so it
> should #include the appropriate files to prevent build errors.
>
> ../arch/x86/include/asm/pci_x86.h:150:10: error: ‘EINVAL’ undeclared (first use in this function)
> return -EINVAL;
>
> ../arch/x86/include/asm/pci_x86.h:105:8: error: unknown type name ‘raw_spinlock_t’
> extern raw_spinlock_t pci_config_lock;
>
> ../arch/x86/include/asm/pci_x86.h:141:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘dmi_check_pciprobe’
> extern void __init dmi_check_pciprobe(void);
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Thanks, applied to pci/misc for v5.18.
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: x86@kernel.org
> Cc: linux-pci@vger.kernel.org
> ---
> Without this patch, I am seeing *many* build errors in
> linux-next-20220225.
>
> I don't know why this showed up in linux-next-20220225 all of a
> sudden.
>
> arch/x86/include/asm/pci_x86.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- linux-next-20220225.orig/arch/x86/include/asm/pci_x86.h
> +++ linux-next-20220225/arch/x86/include/asm/pci_x86.h
> @@ -5,7 +5,10 @@
> * (c) 1999 Martin Mares <mj@ucw.cz>
> */
>
> +#include <linux/errno.h>
> +#include <linux/init.h>
> #include <linux/ioport.h>
> +#include <linux/spinlock.h>
>
> #undef DEBUG
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-14 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-26 21:37 [PATCH -next?] x86: PCI: asm/pci_x86.h needs more #includes Randy Dunlap
2022-03-14 19:54 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).