linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 06/12] MIPS/octeon: use swiotlb_init instead of open coding it
Date: Tue,  1 Mar 2022 12:53:05 +0200	[thread overview]
Message-ID: <20220301105311.885699-7-hch@lst.de> (raw)
In-Reply-To: <20220301105311.885699-1-hch@lst.de>

Use the generic swiotlb initialization helper instead of open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/mips/cavium-octeon/dma-octeon.c | 15 ++-------------
 arch/mips/pci/pci-octeon.c           |  2 +-
 2 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c
index df70308db0e69..fb7547e217263 100644
--- a/arch/mips/cavium-octeon/dma-octeon.c
+++ b/arch/mips/cavium-octeon/dma-octeon.c
@@ -186,15 +186,12 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr)
 	return daddr;
 }
 
-char *octeon_swiotlb;
-
 void __init plat_swiotlb_setup(void)
 {
 	phys_addr_t start, end;
 	phys_addr_t max_addr;
 	phys_addr_t addr_size;
 	size_t swiotlbsize;
-	unsigned long swiotlb_nslabs;
 	u64 i;
 
 	max_addr = 0;
@@ -236,15 +233,7 @@ void __init plat_swiotlb_setup(void)
 	if (OCTEON_IS_OCTEON2() && max_addr >= 0x100000000ul)
 		swiotlbsize = 64 * (1<<20);
 #endif
-	swiotlb_nslabs = swiotlbsize >> IO_TLB_SHIFT;
-	swiotlb_nslabs = ALIGN(swiotlb_nslabs, IO_TLB_SEGSIZE);
-	swiotlbsize = swiotlb_nslabs << IO_TLB_SHIFT;
-
-	octeon_swiotlb = memblock_alloc_low(swiotlbsize, PAGE_SIZE);
-	if (!octeon_swiotlb)
-		panic("%s: Failed to allocate %zu bytes align=%lx\n",
-		      __func__, swiotlbsize, PAGE_SIZE);
 
-	if (swiotlb_init_with_tbl(octeon_swiotlb, swiotlb_nslabs, 1) == -ENOMEM)
-		panic("Cannot allocate SWIOTLB buffer");
+	swiotlb_adjust_size(swiotlbsize);
+	swiotlb_init(1);
 }
diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c
index fc29b85cfa926..e457a18cbdc59 100644
--- a/arch/mips/pci/pci-octeon.c
+++ b/arch/mips/pci/pci-octeon.c
@@ -664,7 +664,7 @@ static int __init octeon_pci_setup(void)
 
 		/* BAR1 movable regions contiguous to cover the swiotlb */
 		octeon_bar1_pci_phys =
-			virt_to_phys(octeon_swiotlb) & ~((1ull << 22) - 1);
+			io_tlb_default_mem.start & ~((1ull << 22) - 1);
 
 		for (index = 0; index < 32; index++) {
 			union cvmx_pci_bar1_indexx bar1_index;
-- 
2.30.2


  parent reply	other threads:[~2022-03-01 10:53 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 10:52 cleanup swiotlb initialization v4 Christoph Hellwig
2022-03-01 10:53 ` [PATCH 01/12] dma-direct: use is_swiotlb_active in dma_direct_map_page Christoph Hellwig
2022-03-01 10:53 ` [PATCH 02/12] swiotlb: make swiotlb_exit a no-op if SWIOTLB_FORCE is set Christoph Hellwig
2022-03-01 10:53 ` [PATCH 03/12] swiotlb: simplify swiotlb_max_segment Christoph Hellwig
2022-03-01 10:53 ` [PATCH 04/12] swiotlb: rename swiotlb_late_init_with_default_size Christoph Hellwig
2022-03-01 10:53 ` [PATCH 05/12] swiotlb: pass a gfp_mask argument to swiotlb_init_late Christoph Hellwig
2022-03-01 10:53 ` Christoph Hellwig [this message]
2022-03-03 16:39   ` [PATCH 06/12] MIPS/octeon: use swiotlb_init instead of open coding it Thomas Bogendoerfer
2022-03-01 10:53 ` [PATCH 07/12] x86: remove the IOMMU table infrastructure Christoph Hellwig
2022-03-01 10:53 ` [PATCH 08/12] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled Christoph Hellwig
2022-03-01 11:39   ` Andrew Cooper
2022-03-01 11:43     ` Christoph Hellwig
2022-03-01 10:53 ` [PATCH 09/12] swiotlb: make the swiotlb_init interface more useful Christoph Hellwig
2022-03-01 10:53 ` [PATCH 10/12] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction Christoph Hellwig
2022-03-04 18:12   ` Michael Kelley (LINUX)
2022-03-04 18:27     ` Dongli Zhang
2022-03-06 17:01       ` Michael Kelley (LINUX)
2022-03-01 10:53 ` [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb Christoph Hellwig
2022-03-02  2:55   ` Stefano Stabellini
2022-03-02  8:15     ` Christoph Hellwig
2022-03-03  1:25       ` Stefano Stabellini
2022-03-03 10:59         ` Christoph Hellwig
2022-03-03 22:49           ` Stefano Stabellini
2022-03-04 16:34             ` Christoph Hellwig
2022-03-04 23:22               ` Stefano Stabellini
2022-03-02 13:15     ` Boris Ostrovsky
2022-03-02 13:17       ` Boris Ostrovsky
2022-03-03 10:57       ` Christoph Hellwig
2022-03-03 19:06         ` Boris Ostrovsky
2022-03-04 17:28       ` Christoph Hellwig
2022-03-04 17:36         ` Boris Ostrovsky
2022-03-04 17:43           ` Christoph Hellwig
2022-03-04 20:18             ` Boris Ostrovsky
2022-03-04 21:03               ` Christoph Hellwig
2022-03-08 21:38   ` Boris Ostrovsky
2022-03-09  6:18     ` Christoph Hellwig
2022-03-09 15:18       ` Boris Ostrovsky
2022-03-01 10:53 ` [PATCH 12/12] x86: remove cruft from <asm/dma-mapping.h> Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301105311.885699-7-hch@lst.de \
    --to=hch@lst.de \
    --cc=anshuman.khandual@arm.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jgross@suse.com \
    --cc=joro@8bytes.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=robin.murphy@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=tboot-devel@lists.sourceforge.net \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).