linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Anshuman Khandual <anshuman.khandual@arm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 08/12] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled
Date: Tue,  1 Mar 2022 12:53:07 +0200	[thread overview]
Message-ID: <20220301105311.885699-9-hch@lst.de> (raw)
In-Reply-To: <20220301105311.885699-1-hch@lst.de>

Move enabling SWIOTLB_FORCE for guest memory encryption into common code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/x86/kernel/cpu/mshyperv.c | 8 --------
 arch/x86/kernel/pci-dma.c      | 7 +++++++
 arch/x86/mm/mem_encrypt_amd.c  | 3 ---
 3 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index 5a99f993e6392..568274917f1cd 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -336,14 +336,6 @@ static void __init ms_hyperv_init_platform(void)
 			swiotlb_unencrypted_base = ms_hyperv.shared_gpa_boundary;
 #endif
 		}
-
-#ifdef CONFIG_SWIOTLB
-		/*
-		 * Enable swiotlb force mode in Isolation VM to
-		 * use swiotlb bounce buffer for dma transaction.
-		 */
-		swiotlb_force = SWIOTLB_FORCE;
-#endif
 	}
 
 	if (hv_max_functions_eax >= HYPERV_CPUID_NESTED_FEATURES) {
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 2ac0ef9c2fb76..7ab7002758396 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -53,6 +53,13 @@ static void __init pci_swiotlb_detect(void)
 	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
 		x86_swiotlb_enable = true;
 
+	/*
+	 * Guest with guest memory encryption must always do I/O through a
+	 * bounce buffer as the hypervisor can't access arbitrary VM memory.
+	 */
+	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT))
+		swiotlb_force = SWIOTLB_FORCE;
+
 	if (swiotlb_force == SWIOTLB_FORCE)
 		x86_swiotlb_enable = true;
 }
diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c
index 2b2d018ea3450..a72942d569cf9 100644
--- a/arch/x86/mm/mem_encrypt_amd.c
+++ b/arch/x86/mm/mem_encrypt_amd.c
@@ -191,9 +191,6 @@ void __init sme_early_init(void)
 	/* Update the protection map with memory encryption mask */
 	for (i = 0; i < ARRAY_SIZE(protection_map); i++)
 		protection_map[i] = pgprot_encrypted(protection_map[i]);
-
-	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT))
-		swiotlb_force = SWIOTLB_FORCE;
 }
 
 void __init sev_setup_arch(void)
-- 
2.30.2


  parent reply	other threads:[~2022-03-01 10:54 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 10:52 cleanup swiotlb initialization v4 Christoph Hellwig
2022-03-01 10:53 ` [PATCH 01/12] dma-direct: use is_swiotlb_active in dma_direct_map_page Christoph Hellwig
2022-03-01 10:53 ` [PATCH 02/12] swiotlb: make swiotlb_exit a no-op if SWIOTLB_FORCE is set Christoph Hellwig
2022-03-01 10:53 ` [PATCH 03/12] swiotlb: simplify swiotlb_max_segment Christoph Hellwig
2022-03-01 10:53 ` [PATCH 04/12] swiotlb: rename swiotlb_late_init_with_default_size Christoph Hellwig
2022-03-01 10:53 ` [PATCH 05/12] swiotlb: pass a gfp_mask argument to swiotlb_init_late Christoph Hellwig
2022-03-01 10:53 ` [PATCH 06/12] MIPS/octeon: use swiotlb_init instead of open coding it Christoph Hellwig
2022-03-03 16:39   ` Thomas Bogendoerfer
2022-03-01 10:53 ` [PATCH 07/12] x86: remove the IOMMU table infrastructure Christoph Hellwig
2022-03-01 10:53 ` Christoph Hellwig [this message]
2022-03-01 11:39   ` [PATCH 08/12] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled Andrew Cooper
2022-03-01 11:43     ` Christoph Hellwig
2022-03-01 10:53 ` [PATCH 09/12] swiotlb: make the swiotlb_init interface more useful Christoph Hellwig
2022-03-01 10:53 ` [PATCH 10/12] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction Christoph Hellwig
2022-03-04 18:12   ` Michael Kelley (LINUX)
2022-03-04 18:27     ` Dongli Zhang
2022-03-06 17:01       ` Michael Kelley (LINUX)
2022-03-01 10:53 ` [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb Christoph Hellwig
2022-03-02  2:55   ` Stefano Stabellini
2022-03-02  8:15     ` Christoph Hellwig
2022-03-03  1:25       ` Stefano Stabellini
2022-03-03 10:59         ` Christoph Hellwig
2022-03-03 22:49           ` Stefano Stabellini
2022-03-04 16:34             ` Christoph Hellwig
2022-03-04 23:22               ` Stefano Stabellini
2022-03-02 13:15     ` Boris Ostrovsky
2022-03-02 13:17       ` Boris Ostrovsky
2022-03-03 10:57       ` Christoph Hellwig
2022-03-03 19:06         ` Boris Ostrovsky
2022-03-04 17:28       ` Christoph Hellwig
2022-03-04 17:36         ` Boris Ostrovsky
2022-03-04 17:43           ` Christoph Hellwig
2022-03-04 20:18             ` Boris Ostrovsky
2022-03-04 21:03               ` Christoph Hellwig
2022-03-08 21:38   ` Boris Ostrovsky
2022-03-09  6:18     ` Christoph Hellwig
2022-03-09 15:18       ` Boris Ostrovsky
2022-03-01 10:53 ` [PATCH 12/12] x86: remove cruft from <asm/dma-mapping.h> Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301105311.885699-9-hch@lst.de \
    --to=hch@lst.de \
    --cc=anshuman.khandual@arm.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jgross@suse.com \
    --cc=joro@8bytes.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=robin.murphy@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=tboot-devel@lists.sourceforge.net \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).